From: Qian Cai <cai@lca.pw>
To: Anju T Sudhakar <anju@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] powerpc/imc: Dont create debugfs files for cpu-less nodes
Date: Wed, 30 Oct 2019 14:37:41 -0400 [thread overview]
Message-ID: <1572460661.5937.104.camel@lca.pw> (raw)
In-Reply-To: <b1d6a06f-5f3b-d887-27cf-ba8c0255c4b0@linux.vnet.ibm.com>
On Tue, 2019-07-23 at 16:57 +0530, Anju T Sudhakar wrote:
> Hi Qian,
>
> On 7/16/19 12:11 AM, Qian Cai wrote:
> > On Thu, 2019-07-11 at 14:53 +1000, Michael Ellerman wrote:
> > > Hi Maddy,
> > >
> > > Madhavan Srinivasan <maddy@linux.vnet.ibm.com> writes:
> > > > diff --git a/arch/powerpc/platforms/powernv/opal-imc.c
> > > > b/arch/powerpc/platforms/powernv/opal-imc.c
> > > > index 186109bdd41b..e04b20625cb9 100644
> > > > --- a/arch/powerpc/platforms/powernv/opal-imc.c
> > > > +++ b/arch/powerpc/platforms/powernv/opal-imc.c
> > > > @@ -69,20 +69,20 @@ static void export_imc_mode_and_cmd(struct device_node
> > > > *node,
> > > > if (of_property_read_u32(node, "cb_offset", &cb_offset))
> > > > cb_offset = IMC_CNTL_BLK_OFFSET;
> > > >
> > > > - for_each_node(nid) {
> > > > - loc = (u64)(pmu_ptr->mem_info[chip].vbase) + cb_offset;
> > > > + while (ptr->vbase != NULL) {
> > >
> > > This means you'll bail out as soon as you find a node with no vbase, but
> > > it's possible we could have a CPU-less node intermingled with other
> > > nodes.
> > >
> > > So I think you want to keep the for loop, but continue if you see a NULL
> > > vbase?
> >
> > Not sure if this will also takes care of some of those messages during the boot
> > on today's linux-next even without this patch.
> >
> >
> > [ 18.077780][ T1] debugfs: Directory 'imc' with parent 'powerpc' already
> > present!
> >
> >
>
> This is introduced by a recent commit: c33d442328f55 (debugfs: make
> error message a bit more verbose).
>
> So basically, the debugfs imc_* file is created per node, and is created
> by the first nest unit which is
>
> being registered. For the subsequent nest units, debugfs_create_dir()
> will just return since the imc_* file already
>
> exist.
>
> The commit "c33d442328f55 (debugfs: make error message a bit more
> verbose)", prints
>
> a message if the debugfs file already exists in debugfs_create_dir().
> That is why we are encountering these
>
> messages now.
>
>
> This patch (i.e, powerpc/imc: Dont create debugfs files for cpu-less
> nodes) will address the initial issue, i.e
>
> "numa crash while reading imc_* debugfs files for cpu less nodes", and
> will not address these debugfs messages.
>
>
> But yeah this is a good catch. We can have some checks to avoid these
> debugfs messages.
Anju, do you still plan to fix those "Directory 'imc' with parent 'powerpc'
already present!" warnings as they are still there in the latest linux-next?
>
>
> Hi Michael,
>
> Do we need to have a separate patch to address these debugfs messages,
> or can we address the same
>
> in the next version of this patch itself?
>
>
> Thanks,
>
> Anju
>
>
>
>
prev parent reply other threads:[~2019-10-30 18:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 9:21 [PATCH v2] powerpc/imc: Dont create debugfs files for cpu-less nodes Madhavan Srinivasan
2019-07-11 4:53 ` Michael Ellerman
2019-07-15 6:22 ` maddy
2019-07-15 18:41 ` Qian Cai
2019-07-23 11:27 ` Anju T Sudhakar
2019-07-29 12:36 ` Michael Ellerman
2019-10-30 18:37 ` Qian Cai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572460661.5937.104.camel@lca.pw \
--to=cai@lca.pw \
--cc=anju@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).