* [PATCH -next] powerpc/powernv: make symbol 'mpipl_kobj' static
@ 2021-04-09 6:38 Bixuan Cui
2021-04-19 3:59 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Bixuan Cui @ 2021-04-09 6:38 UTC (permalink / raw)
To: cuibixuan, Michael Ellerman, Qinglang Miao, Al Viro
Cc: kernel-janitors, linuxppc-dev, linux-kernel
The sparse tool complains as follows:
arch/powerpc/platforms/powernv/opal-core.c:74:16: warning:
symbol 'mpipl_kobj' was not declared.
This symbol is not used outside of opal-core.c, so marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
arch/powerpc/platforms/powernv/opal-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/opal-core.c b/arch/powerpc/platforms/powernv/opal-core.c
index 0d9ba70f7251..5b9736bbc2aa 100644
--- a/arch/powerpc/platforms/powernv/opal-core.c
+++ b/arch/powerpc/platforms/powernv/opal-core.c
@@ -71,7 +71,7 @@ static LIST_HEAD(opalcore_list);
static struct opalcore_config *oc_conf;
static const struct opal_mpipl_fadump *opalc_metadata;
static const struct opal_mpipl_fadump *opalc_cpu_metadata;
-struct kobject *mpipl_kobj;
+static struct kobject *mpipl_kobj;
/*
* Set crashing CPU's signal to SIGUSR1. if the kernel is triggered
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] powerpc/powernv: make symbol 'mpipl_kobj' static
2021-04-09 6:38 [PATCH -next] powerpc/powernv: make symbol 'mpipl_kobj' static Bixuan Cui
@ 2021-04-19 3:59 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2021-04-19 3:59 UTC (permalink / raw)
To: Al Viro, Michael Ellerman, Qinglang Miao, Bixuan Cui
Cc: linuxppc-dev, kernel-janitors, linux-kernel
On Fri, 9 Apr 2021 14:38:55 +0800, Bixuan Cui wrote:
> The sparse tool complains as follows:
>
> arch/powerpc/platforms/powernv/opal-core.c:74:16: warning:
> symbol 'mpipl_kobj' was not declared.
>
> This symbol is not used outside of opal-core.c, so marks it static.
Applied to powerpc/next.
[1/1] powerpc/powernv: make symbol 'mpipl_kobj' static
https://git.kernel.org/powerpc/c/ff0b4155ae9903539d1299a9a4c8717fb7eb6009
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-19 4:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 6:38 [PATCH -next] powerpc/powernv: make symbol 'mpipl_kobj' static Bixuan Cui
2021-04-19 3:59 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).