LinuxPPC-Dev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] powerpc/configs: Add PAPR_SCM to pseries_defconfig
@ 2021-04-16 11:12 Michael Ellerman
  2021-04-16 11:12 ` [PATCH 2/2] powerpc/papr_scm: Fix build error due to wrong printf specifier Michael Ellerman
  2021-04-19  4:12 ` [PATCH 1/2] powerpc/configs: Add PAPR_SCM to pseries_defconfig Michael Ellerman
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Ellerman @ 2021-04-16 11:12 UTC (permalink / raw)
  To: linuxppc-dev

This is a pseries only driver, it should be built by default as part of
pseries_defconfig to get some build coverage.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 arch/powerpc/configs/pseries_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
index 777221775c83..968095d7682c 100644
--- a/arch/powerpc/configs/pseries_defconfig
+++ b/arch/powerpc/configs/pseries_defconfig
@@ -41,6 +41,7 @@ CONFIG_DTL=y
 CONFIG_SCANLOG=m
 CONFIG_PPC_SMLPAR=y
 CONFIG_IBMEBUS=y
+CONFIG_PAPR_SCM=m
 CONFIG_PPC_SVM=y
 # CONFIG_PPC_PMAC is not set
 CONFIG_RTAS_FLASH=m
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] powerpc/papr_scm: Fix build error due to wrong printf specifier
  2021-04-16 11:12 [PATCH 1/2] powerpc/configs: Add PAPR_SCM to pseries_defconfig Michael Ellerman
@ 2021-04-16 11:12 ` Michael Ellerman
  2021-04-19  4:12 ` [PATCH 1/2] powerpc/configs: Add PAPR_SCM to pseries_defconfig Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2021-04-16 11:12 UTC (permalink / raw)
  To: linuxppc-dev

When I changed the rc variable to be long rather than int64_t I
neglected to update the printk(), leading to a build break:

  arch/powerpc/platforms/pseries/papr_scm.c: In function 'papr_scm_pmem_flush':
  arch/powerpc/platforms/pseries/papr_scm.c:144:26: warning: format
    '%lld' expects argument of type 'long long int', but argument 3 has
    type 'long int' [-Wformat=]

Fixes: 75b7c05ebf90 ("powerpc/papr_scm: Implement support for H_SCM_FLUSH hcall")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 arch/powerpc/platforms/pseries/papr_scm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
index ae6f5d80d5ce..48de21902116 100644
--- a/arch/powerpc/platforms/pseries/papr_scm.c
+++ b/arch/powerpc/platforms/pseries/papr_scm.c
@@ -141,7 +141,7 @@ static int papr_scm_pmem_flush(struct nd_region *nd_region,
 	} while (rc == H_BUSY);
 
 	if (rc) {
-		dev_err(&p->pdev->dev, "flush error: %lld", rc);
+		dev_err(&p->pdev->dev, "flush error: %ld", rc);
 		rc = -EIO;
 	} else {
 		dev_dbg(&p->pdev->dev, "flush drc 0x%x complete", p->drc_index);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] powerpc/configs: Add PAPR_SCM to pseries_defconfig
  2021-04-16 11:12 [PATCH 1/2] powerpc/configs: Add PAPR_SCM to pseries_defconfig Michael Ellerman
  2021-04-16 11:12 ` [PATCH 2/2] powerpc/papr_scm: Fix build error due to wrong printf specifier Michael Ellerman
@ 2021-04-19  4:12 ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2021-04-19  4:12 UTC (permalink / raw)
  To: linuxppc-dev, Michael Ellerman

On Fri, 16 Apr 2021 21:12:08 +1000, Michael Ellerman wrote:
> This is a pseries only driver, it should be built by default as part of
> pseries_defconfig to get some build coverage.

Applied to powerpc/next.

[1/2] powerpc/configs: Add PAPR_SCM to pseries_defconfig
      https://git.kernel.org/powerpc/c/d6481a7195df4a8c828f9ee0b382f2dd36d3575c
[2/2] powerpc/papr_scm: Fix build error due to wrong printf specifier
      https://git.kernel.org/powerpc/c/7767d9ac89cee29c68f5dd278b3bb411d1c69287

cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 11:12 [PATCH 1/2] powerpc/configs: Add PAPR_SCM to pseries_defconfig Michael Ellerman
2021-04-16 11:12 ` [PATCH 2/2] powerpc/papr_scm: Fix build error due to wrong printf specifier Michael Ellerman
2021-04-19  4:12 ` [PATCH 1/2] powerpc/configs: Add PAPR_SCM to pseries_defconfig Michael Ellerman

LinuxPPC-Dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linuxppc-dev/0 linuxppc-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linuxppc-dev linuxppc-dev/ https://lore.kernel.org/linuxppc-dev \
		linuxppc-dev@lists.ozlabs.org linuxppc-dev@ozlabs.org
	public-inbox-index linuxppc-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.ozlabs.lists.linuxppc-dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git