From: Nicholas Piggin <npiggin@gmail.com>
To: Haren Myneni <haren@linux.ibm.com>,
herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au
Subject: Re: [PATCH v5 11/17] powerpc/pseries/vas: Implement getting capabilities from hypervisor
Date: Mon, 14 Jun 2021 12:35:50 +1000 [thread overview]
Message-ID: <1623637992.3jr2j7txx9.astroid@bobo.none> (raw)
In-Reply-To: <4ca037732838675bd8e12de702687971e0ab2b3d.camel@linux.ibm.com>
Excerpts from Haren Myneni's message of June 13, 2021 9:01 pm:
>
> The hypervisor provides VAS capabilities for GZIP default and QoS
> features. These capabilities gives information for the specific
> features such as total number of credits available in LPAR,
> maximum credits allowed per window, maximum credits allowed in
> LPAR, whether usermode copy/paste is supported, and etc.
>
> This patch adds the following:
> - Retrieve all features that are provided by hypervisor using
> H_QUERY_VAS_CAPABILITIES hcall with 0 as feature type.
> - Retrieve capabilities for the specific feature using the same
> hcall and the feature type (1 for QoS and 2 for default type).
>
> Signed-off-by: Haren Myneni <haren@linux.ibm.com>
> ---
> arch/powerpc/platforms/pseries/vas.c | 124 +++++++++++++++++++++++++++
> 1 file changed, 124 insertions(+)
>
> diff --git a/arch/powerpc/platforms/pseries/vas.c b/arch/powerpc/platforms/pseries/vas.c
> index fec280979d50..98109a13f1c2 100644
> --- a/arch/powerpc/platforms/pseries/vas.c
> +++ b/arch/powerpc/platforms/pseries/vas.c
> @@ -10,6 +10,7 @@
> #include <linux/export.h>
> #include <linux/types.h>
> #include <linux/delay.h>
> +#include <asm/machdep.h>
> #include <asm/hvcall.h>
> #include <asm/plpar_wrappers.h>
> #include <asm/vas.h>
> @@ -20,6 +21,13 @@
> /* phyp allows one credit per window right now */
> #define DEF_WIN_CREDS 1
>
> +static struct vas_all_caps caps_all;
> +static bool copypaste_feat;
> +
> +static struct vas_caps vascaps[VAS_MAX_FEAT_TYPE];
If these will all be read by later patches I think that's okay,
however:
> +
> +static DEFINE_MUTEX(vas_pseries_mutex);
This is not used at all. It should be added in the patch that uses it.
Thanks,
Nick
> +
> static long hcall_return_busy_check(long rc)
> {
> /* Check if we are stalled for some time */
> @@ -179,3 +187,119 @@ int h_query_vas_capabilities(const u64 hcall, u8 query_type, u64 result)
> return -EIO;
> }
> }
> +
> +/*
> + * Get the specific capabilities based on the feature type.
> + * Right now supports GZIP default and GZIP QoS capabilities.
> + */
> +static int get_vas_capabilities(u8 feat, enum vas_cop_feat_type type,
> + struct hv_vas_ct_caps *hv_caps)
> +{
> + struct vas_ct_caps *caps;
> + struct vas_caps *vcaps;
> + int rc = 0;
> +
> + vcaps = &vascaps[type];
> + memset(vcaps, 0, sizeof(*vcaps));
> + INIT_LIST_HEAD(&vcaps->list);
> +
> + caps = &vcaps->caps;
> +
> + rc = h_query_vas_capabilities(H_QUERY_VAS_CAPABILITIES, feat,
> + (u64)virt_to_phys(hv_caps));
> + if (rc)
> + return rc;
> +
> + caps->user_mode = hv_caps->user_mode;
> + if (!(caps->user_mode & VAS_COPY_PASTE_USER_MODE)) {
> + pr_err("User space COPY/PASTE is not supported\n");
> + return -ENOTSUPP;
> + }
> +
> + caps->descriptor = be64_to_cpu(hv_caps->descriptor);
> + caps->win_type = hv_caps->win_type;
> + if (caps->win_type >= VAS_MAX_FEAT_TYPE) {
> + pr_err("Unsupported window type %u\n", caps->win_type);
> + return -EINVAL;
> + }
> + caps->max_lpar_creds = be16_to_cpu(hv_caps->max_lpar_creds);
> + caps->max_win_creds = be16_to_cpu(hv_caps->max_win_creds);
> + atomic_set(&caps->target_lpar_creds,
> + be16_to_cpu(hv_caps->target_lpar_creds));
> + if (feat == VAS_GZIP_DEF_FEAT) {
> + caps->def_lpar_creds = be16_to_cpu(hv_caps->def_lpar_creds);
> +
> + if (caps->max_win_creds < DEF_WIN_CREDS) {
> + pr_err("Window creds(%u) > max allowed window creds(%u)\n",
> + DEF_WIN_CREDS, caps->max_win_creds);
> + return -EINVAL;
> + }
> + }
> +
> + copypaste_feat = true;
> +
> + return 0;
> +}
> +
> +static int __init pseries_vas_init(void)
> +{
> + struct hv_vas_ct_caps *hv_ct_caps;
> + struct hv_vas_all_caps *hv_caps;
> + int rc;
> +
> + /*
> + * Linux supports user space COPY/PASTE only with Radix
> + */
> + if (!radix_enabled()) {
> + pr_err("API is supported only with radix page tables\n");
> + return -ENOTSUPP;
> + }
> +
> + hv_caps = kmalloc(sizeof(*hv_caps), GFP_KERNEL);
> + if (!hv_caps)
> + return -ENOMEM;
> + /*
> + * Get VAS overall capabilities by passing 0 to feature type.
> + */
> + rc = h_query_vas_capabilities(H_QUERY_VAS_CAPABILITIES, 0,
> + (u64)virt_to_phys(hv_caps));
> + if (rc)
> + goto out;
> +
> + caps_all.descriptor = be64_to_cpu(hv_caps->descriptor);
> + caps_all.feat_type = be64_to_cpu(hv_caps->feat_type);
> +
> + hv_ct_caps = kmalloc(sizeof(*hv_ct_caps), GFP_KERNEL);
> + if (!hv_ct_caps) {
> + rc = -ENOMEM;
> + goto out;
> + }
> + /*
> + * QOS capabilities available
> + */
> + if (caps_all.feat_type & VAS_GZIP_QOS_FEAT_BIT) {
> + rc = get_vas_capabilities(VAS_GZIP_QOS_FEAT,
> + VAS_GZIP_QOS_FEAT_TYPE, hv_ct_caps);
> +
> + if (rc)
> + goto out_ct;
> + }
> + /*
> + * Default capabilities available
> + */
> + if (caps_all.feat_type & VAS_GZIP_DEF_FEAT_BIT) {
> + rc = get_vas_capabilities(VAS_GZIP_DEF_FEAT,
> + VAS_GZIP_DEF_FEAT_TYPE, hv_ct_caps);
> + if (rc)
> + goto out_ct;
> + }
> +
> + pr_info("GZIP feature is available\n");
> +
> +out_ct:
> + kfree(hv_ct_caps);
> +out:
> + kfree(hv_caps);
> + return rc;
> +}
> +machine_device_initcall(pseries, pseries_vas_init);
> --
> 2.18.2
>
>
>
next prev parent reply other threads:[~2021-06-14 2:36 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 10:53 [PATCH v5 00/17] Enable VAS and NX-GZIP support on PowerVM Haren Myneni
2021-06-13 10:54 ` [PATCH v5 01/17] powerpc/powernv/vas: Release reference to tgid during window close Haren Myneni
2021-06-14 2:11 ` Nicholas Piggin
2021-06-13 10:55 ` [PATCH v5 02/17] powerpc/vas: Move VAS API to book3s common platform Haren Myneni
2021-06-14 2:10 ` Nicholas Piggin
2021-06-13 10:56 ` [PATCH v5 03/17] powerpc/powernv/vas: Rename register/unregister functions Haren Myneni
2021-06-13 10:57 ` [PATCH v5 04/17] powerpc/vas: Add platform specific user window operations Haren Myneni
2021-06-14 2:24 ` Nicholas Piggin
2021-06-15 6:37 ` Haren Myneni
2021-06-16 9:11 ` Nicholas Piggin
2021-06-13 10:57 ` [PATCH v5 05/17] powerpc/vas: Create take/drop pid and mm reference functions Haren Myneni
2021-06-14 2:26 ` Nicholas Piggin
2021-06-13 10:58 ` [PATCH v5 06/17] powerpc/vas: Move update_csb/dump_crb to common book3s platform Haren Myneni
2021-06-14 3:34 ` Nicholas Piggin
2021-06-13 10:58 ` [PATCH v5 07/17] powerpc/vas: Define and use common vas_window struct Haren Myneni
2021-06-14 2:28 ` Nicholas Piggin
2021-06-13 10:59 ` [PATCH v5 08/17] powerpc/pseries/vas: Define VAS/NXGZIP hcalls and structs Haren Myneni
2021-06-14 2:32 ` Nicholas Piggin
2021-06-13 11:00 ` [PATCH v5 09/17] powerpc/vas: Define QoS credit flag to allocate window Haren Myneni
2021-06-14 2:32 ` Nicholas Piggin
2021-06-13 11:00 ` [PATCH v5 10/17] powerpc/pseries/vas: Add hcall wrappers for VAS handling Haren Myneni
2021-06-13 11:01 ` [PATCH v5 11/17] powerpc/pseries/vas: Implement getting capabilities from hypervisor Haren Myneni
2021-06-14 2:35 ` Nicholas Piggin [this message]
2021-06-13 11:02 ` [PATCH v5 12/17] powerpc/pseries/vas: Integrate API with open/close windows Haren Myneni
2021-06-14 2:55 ` Nicholas Piggin
2021-06-15 6:51 ` Haren Myneni
2021-06-15 7:26 ` Haren Myneni
2021-06-16 9:38 ` Nicholas Piggin
2021-06-13 11:02 ` [PATCH v5 13/17] powerpc/pseries/vas: Setup IRQ and fault handling Haren Myneni
2021-06-14 3:07 ` Nicholas Piggin
2021-06-15 9:01 ` Haren Myneni
2021-06-16 9:40 ` Nicholas Piggin
2021-06-13 11:03 ` [PATCH v5 14/17] crypto/nx: Rename nx-842-pseries file name to nx-common-pseries Haren Myneni
2021-06-14 3:07 ` Nicholas Piggin
2021-06-13 11:04 ` [PATCH v5 15/17] crypto/nx: Register and unregister VAS interface on PowerVM Haren Myneni
2021-06-14 3:35 ` Nicholas Piggin
2021-06-13 11:04 ` [PATCH v5 16/17] crypto/nx: Get NX capabilities for GZIP coprocessor type Haren Myneni
2021-06-14 3:39 ` Nicholas Piggin
2021-06-15 0:01 ` Haren Myneni
2021-06-13 11:05 ` [PATCH v5 17/17] crypto/nx: Add sysfs interface to export NX capabilities Haren Myneni
2021-06-14 3:46 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623637992.3jr2j7txx9.astroid@bobo.none \
--to=npiggin@gmail.com \
--cc=haren@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).