linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
	linuxppc-dev@lists.ozlabs.org,
	Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH v2] powerpc/64s: introduce CONFIG_MAXSMP to test very large SMP
Date: Tue, 23 Nov 2021 15:16:53 +1000	[thread overview]
Message-ID: <1637644502.lzs9delw7v.astroid@bobo.none> (raw)
In-Reply-To: <1637644417.rd9apgh5k7.astroid@bobo.none>

Excerpts from Nicholas Piggin's message of November 23, 2021 3:14 pm:
> Excerpts from Michael Ellerman's message of November 23, 2021 11:01 am:
>> Michael Ellerman <mpe@ellerman.id.au> writes:
>>> Christophe Leroy <christophe.leroy@csgroup.eu> writes:
>>>> Le 09/11/2021 à 07:51, Nicholas Piggin a écrit :
>>> ...
>>>>> diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
>>>>> index a208997ade88..14c275e0ff93 100644
>>>>> --- a/arch/powerpc/platforms/Kconfig.cputype
>>>>> +++ b/arch/powerpc/platforms/Kconfig.cputype
>>>>> @@ -475,9 +475,14 @@ config SMP
>>>>>   
>>>>>   	  If you don't know what to do here, say N.
>>>>>   
>>>>> +# MAXSMP sets 8192 if COMPILE_TEST because that's what x86 has flushed out.
>>>>> +# Exceeding that will cause a lot of compile errors. Have to deal with those
>>>>> +# first.
>>>>>   config NR_CPUS
>>>>> -	int "Maximum number of CPUs (2-8192)" if SMP
>>>>> -	range 2 8192 if SMP
>>>>> +	int "Maximum number of CPUs (2-8192)" if SMP && !MAXSMP
>>>>> +	range 2 16384 if SMP
>>>>> +	default 16384 if MAXSMP && !COMPILE_TEST
>>>>> +	default 8192 if MAXSMP && COMPILE_TEST
>>>>
>>>> You can do less complex. First hit becomes the default, so you can do:
>>>>
>>>> 	default 8192 if MAXSMP && COMPILE_TEST
>>>> 	default 16384 if MAXSMP
>>>
>>> I did that when applying.
>> 
>> But I'll have to drop it, it breaks the allyesconfig build:
> 
> Ah, you still need patch 1/2 sorry I confused things by only re-sending 
> this one.
> 
> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20211105035042.1398309-1-npiggin@gmail.com/

Actually KVM will also be broken, I sent a patch for it but there is 
some discussion of fixing it a different way. So maybe leave out the
maxsmp patch for now (or make it depend on BROKEN?). I can re-send
maybe next merge window if the other pieces are in place.

If you could still take that ^^ patch for now would be good though.

Thanks,
Nick

      reply	other threads:[~2021-11-23  5:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09  6:51 [PATCH v2] powerpc/64s: introduce CONFIG_MAXSMP to test very large SMP Nicholas Piggin
2021-11-09 16:16 ` Christophe Leroy
2021-11-11 10:32   ` Michael Ellerman
2021-11-23  1:01     ` Michael Ellerman
2021-11-23  5:14       ` Nicholas Piggin
2021-11-23  5:16         ` Nicholas Piggin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1637644502.lzs9delw7v.astroid@bobo.none \
    --to=npiggin@gmail.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).