From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: llvm@lists.linux.dev, Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/2] recordmcount: Handle sections with no non-weak symbols
Date: Thu, 28 Apr 2022 23:01:09 +0530 [thread overview]
Message-ID: <1651166901.se7n53e6x9.naveen@linux.ibm.com> (raw)
In-Reply-To: <20220428100602.7b215e52@gandalf.local.home>
Steven Rostedt wrote:
> On Thu, 28 Apr 2022 13:15:22 +0530
> "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
>
>> Indeed, plain old -pg will be a problem. I'm not sure there is a generic
>> way to address this. I suppose architectures will have to validate the
>> mcount locations, something like this?
>
> Perhaps another solution is to make the mcount locations after the linking
> is done. The main downside to that is that it takes time to go over the
> entire vmlinux, and will slow down a compile that only modified a couple of
> files.
Yes, and I think that is also very useful with LTO. So, that would be
good to consider in the longer term.
For now, I have posted a v2 of this series with your comments addressed.
It is working well in my tests on powerpc in the different
configurations, including the older elf v1 abi with -pg. If it looks ok
to you, we can go with this approach for now.
Thanks,
Naveen
next prev parent reply other threads:[~2022-04-28 17:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 9:31 [PATCH 0/2] ftrace/recordmcount: Handle object files without section symbols Naveen N. Rao
2022-04-27 9:31 ` [PATCH 1/2] ftrace: Drop duplicate mcount locations Naveen N. Rao
2022-04-27 13:46 ` Steven Rostedt
2022-04-27 9:31 ` [PATCH 2/2] recordmcount: Handle sections with no non-weak symbols Naveen N. Rao
2022-04-27 13:54 ` Steven Rostedt
2022-04-28 7:45 ` Naveen N. Rao
2022-04-28 14:06 ` Steven Rostedt
2022-04-28 17:24 ` Naveen N. Rao
2022-04-28 17:31 ` Naveen N. Rao [this message]
2022-05-02 14:44 ` Christophe Leroy
2022-05-02 23:52 ` Steven Rostedt
2022-05-03 11:20 ` Christophe Leroy
2022-05-03 16:25 ` Steven Rostedt
2022-05-04 16:50 ` Christophe Leroy
2022-05-04 17:06 ` Steven Rostedt
2022-05-04 17:10 ` Christophe Leroy
2022-08-16 14:04 ` [PATCH 0/2] ftrace/recordmcount: Handle object files without section symbols Steven Rostedt
2022-08-16 17:05 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1651166901.se7n53e6x9.naveen@linux.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).