linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Cc: linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, Baoquan He <bhe@redhat.com>
Subject: Re: [PATCH] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add]
Date: Thu, 26 May 2022 16:30:22 +0530	[thread overview]
Message-ID: <1653562638.7zk3zmzd88.naveen@linux.ibm.com> (raw)
In-Reply-To: <20220525125627.acf27b28bb67417a6683a1d9@linux-foundation.org>

Andrew Morton wrote:
> On Fri, 20 May 2022 14:25:05 -0500 "Eric W. Biederman" <ebiederm@xmission.com> wrote:
> 
>> > I am not strongly against taking off __weak, just wondering if there's
>> > chance to fix it in recordmcount, and the cost comparing with kernel fix;
>> > except of this issue, any other weakness of __weak. Noticed Andrew has
>> > picked this patch, as a witness of this moment, raise a tiny concern.
>> 
>> I just don't see what else we can realistically do.
> 
> I think converting all of the kexec __weaks to use the ifdef approach
> makes sense, if only because kexec is now using two different styles.
> 
> But for now, I'll send Naveen's v2 patch in to Linus to get us out of
> trouble.

Thanks!

> 
> I'm thinking that we should add cc:stable to that patch as well, to
> reduce the amount of problems which people experience when using newer
> binutils on older kernels?

Yes, please. I missed tagging this for stable. It looks like this is 
applicable all the way back to v4.9 (though I haven't tested if 
recordmcount fails in the same manner with those older kernel levels). I 
will post backports once this gets into linus' tree.


- Naveen

  reply	other threads:[~2022-05-26 11:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 18:18 [PATCH] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add] Naveen N. Rao
2022-05-18 20:47 ` Andrew Morton
2022-05-19  9:13   ` Naveen N. Rao
2022-05-18 21:59 ` Eric W. Biederman
2022-05-19  2:58   ` Baoquan He
2022-05-19  9:28     ` Naveen N. Rao
2022-05-19 17:59     ` Eric W. Biederman
2022-05-20 10:46       ` Baoquan He
2022-05-20 19:25         ` Eric W. Biederman
2022-05-25 19:56           ` Andrew Morton
2022-05-26 11:00             ` Naveen N. Rao [this message]
2022-05-19  5:41 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1653562638.7zk3zmzd88.naveen@linux.ibm.com \
    --to=naveen.n.rao@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).