From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DF44C433FE for ; Fri, 30 Sep 2022 14:38:30 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4MfCX44Vbnz3chg for ; Sat, 1 Oct 2022 00:38:28 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.167.181; helo=mail-oi1-f181.google.com; envelope-from=robherring2@gmail.com; receiver=) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4MfCWY5bMbz3c46 for ; Sat, 1 Oct 2022 00:38:01 +1000 (AEST) Received: by mail-oi1-f181.google.com with SMTP id c81so4928714oif.3 for ; Fri, 30 Sep 2022 07:38:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=jevZr+HvLkIfabkJ9RHCFEAmFsQ/4U9+lScQ8KdTR4U=; b=MyXq9ALhCCaB4man8MrKAb4IrZiomKR0OSh4rw34uTeTgx2Yml75k0nKcm89tCp241 2Rw3KaWZeN+UX6tZ4raTNJvvjcmBmBpWFKMEwvKjJXLR5Kh8XlJOnCalfEXgCq/RrQea SpTxxfYB3KwlrtWEyyBWxZrBIuGeI3hZkhm01wSMrybhdG4BdUUa67yJxuimv501yCGt TUsEk4LjnBZ3ZOsxJsxrKgovh9cqAq16nnbbzCh4YF4dv88DWvdac3V6D8Q2uI0q7+kx 3vzVRzj+siUmuVNJHTEPB3gQTN/62gaLmStiAdKNjrVevcHfKW6FuYgb+xM/RKHzdBey Seww== X-Gm-Message-State: ACrzQf3MtReXuu1UYOACkafQ6bKWpm7ZnJ6bEjY6mjyNdArgnxbJ0sHE fovUA8kzAjsFtiM9dd5eSA== X-Google-Smtp-Source: AMsMyM5kZfkX/Nv7QtAjvly/AOG7XEZvqZmaaiCf9ocGcxeyK9zp/9aBEfwE7rKFBEIa44M8yyWlCQ== X-Received: by 2002:a05:6808:19a:b0:34f:ddfc:5986 with SMTP id w26-20020a056808019a00b0034fddfc5986mr3930580oic.30.1664548677906; Fri, 30 Sep 2022 07:37:57 -0700 (PDT) Received: from macbook.herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id g26-20020a056830161a00b00616d25dc933sm606700otr.69.2022.09.30.07.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 07:37:57 -0700 (PDT) Received: (nullmailer pid 281631 invoked by uid 1000); Fri, 30 Sep 2022 14:37:56 -0000 Date: Fri, 30 Sep 2022 09:37:56 -0500 From: Rob Herring To: Sean Anderson Subject: Re: [PATCH net-next v5 2/9] dt-bindings: net: Add Lynx PCS binding Message-ID: <166454867358.281536.13914577954285422823.robh@kernel.org> References: <20220926190322.2889342-1-sean.anderson@seco.com> <20220926190322.2889342-3-sean.anderson@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220926190322.2889342-3-sean.anderson@seco.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Madalin Bucur , netdev@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Eric Dumazet , Rob Herring , Camelia Alexandra Groza , Krzysztof Kozlowski , Jakub Kicinski , Paolo Abeni , "linuxppc-dev @ lists . ozlabs . org" , "David S . Miller" , linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, 26 Sep 2022 15:03:14 -0400, Sean Anderson wrote: > This binding is fairly bare-bones for now, since the Lynx driver doesn't > parse any properties (or match based on the compatible). We just need it > in order to prevent the PCS nodes from having phy devices attached to > them. This is not really a problem, but it is a bit inefficient. > > This binding is really for three separate PCSs (SGMII, QSGMII, and XFI). > However, the driver treats all of them the same. This works because the > SGMII and XFI devices typically use the same address, and the SerDes > driver (or RCW) muxes between them. The QSGMII PCSs have the same > register layout as the SGMII PCSs. To do things properly, we'd probably > do something like > > ethernet-pcs@0 { > #pcs-cells = <1>; > compatible = "fsl,lynx-pcs"; > reg = <0>, <1>, <2>, <3>; > }; > > but that would add complexity, and we can describe the hardware just > fine using separate PCSs for now. > > Signed-off-by: Sean Anderson > --- > > Changes in v5: > - New > > .../bindings/net/pcs/fsl,lynx-pcs.yaml | 40 +++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/pcs/fsl,lynx-pcs.yaml > Reviewed-by: Rob Herring