From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: jniethe5@gmail.com, Li Huafei <lihuafei1@huawei.com>, mpe@ellerman.id.au
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org,
npiggin@gmail.com, rostedt@goodmis.org,
linuxppc-dev@lists.ozlabs.org, mhiramat@kernel.org
Subject: Re: [PATCH] powerpc/kprobes: Fix null pointer reference in arch_prepare_kprobe()
Date: Wed, 12 Oct 2022 15:22:51 +0530 [thread overview]
Message-ID: <1665565982.bae3snm0nx.naveen@linux.ibm.com> (raw)
In-Reply-To: <de8e524d-02b3-c2d0-45c3-5cc1e5556660@huawei.com>
Li Huafei wrote:
>>>
>>> # echo 'p cmdline_proc_show' > kprobe_events
>>> # echo 'p cmdline_proc_show+16' >> kprobe_events
>>
>> I think we should extend multiple_kprobes selftest to also place
>> contiguous probes to catch such errors.
>>
> Yes. But each architecture implementation is different and it looks a
> little difficult to decide which offsets need to be tested.
I don't think we need to be accurate here. A test to simply try putting
a probe at every byte within the first 256 bytes of a kernel function
should help catch many such issues. Some of those probes will be
rejected, but we can ignore errors.
- Naveen
next prev parent reply other threads:[~2022-10-12 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 9:32 [PATCH] powerpc/kprobes: Fix null pointer reference in arch_prepare_kprobe() Li Huafei
2022-09-30 9:47 ` Naveen N. Rao
2022-10-12 6:14 ` Li Huafei
2022-10-12 9:52 ` Naveen N. Rao [this message]
2022-10-04 13:26 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1665565982.bae3snm0nx.naveen@linux.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=jniethe5@gmail.com \
--cc=lihuafei1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhiramat@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).