RE: Problems with PCI-E devices not being detected with switch

["Ayman El-Khashab" <AymanE@tanisys.com>]

Benjamin Herrenschmidt wrote:

>>>=20
>>> +	/* Check if setup is sensible at all */
>>> +	if ((buses & 0xff) !=3D bus->number ||
>>> +	    ((buses >> 8) & 0xff) !=3D <=3D bus->number) {
>>=20
>> Note that I removed the <=3D from the above line -- I did not think =
it
>> was correct.  Please let me know if that was wrong.
>=20
> My logic is that the current setup is incorrect if the primary bus of
> the bridge doesn't match the parent bus number, or if the secondary
> bus number of the bridge is not strictly superior to the parent bus
> number.  =20
>=20
> What sounds incorrect ?
>=20

The part that didn't look correct is this line (note the operators)

   ((buses >> 8) & 0xff) !=3D <=3D bus->number) {

               Operators ^^ ^^

>From reading through the code and your textual description of what was
supposed to be happening, I went ahead and changed it to ...=20

 ((buses >> 8) & 0xff) !=3D  bus->number) {

And this is the code that generated the results from my previous
message.


Hope that made sense ...

Regards,
Ayman