From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: linuxppc-dev@lists.ozlabs.org, Naveen N Rao <naveen@kernel.org>
Cc: Nicholas Piggin <npiggin@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] powerpc/ftrace: Create a dummy stackframe to fix stack unwind
Date: Sat, 29 Jul 2023 17:48:09 +1000 [thread overview]
Message-ID: <169061688928.236508.2659343767835003491.b4-ty@ellerman.id.au> (raw)
In-Reply-To: <20230621051349.759567-1-naveen@kernel.org>
On Wed, 21 Jun 2023 10:43:49 +0530, Naveen N Rao wrote:
> With ppc64 -mprofile-kernel and ppc32 -pg, profiling instructions to
> call into ftrace are emitted right at function entry. The instruction
> sequence used is minimal to reduce overhead. Crucially, a stackframe is
> not created for the function being traced. This breaks stack unwinding
> since the function being traced does not have a stackframe for itself.
> As such, it never shows up in the backtrace:
>
> [...]
Applied to powerpc/fixes.
[1/1] powerpc/ftrace: Create a dummy stackframe to fix stack unwind
https://git.kernel.org/powerpc/c/41a506ef71eb38d94fe133f565c87c3e06ccc072
cheers
prev parent reply other threads:[~2023-07-29 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 5:13 [PATCH] powerpc/ftrace: Create a dummy stackframe to fix stack unwind Naveen N Rao
2023-07-29 7:48 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169061688928.236508.2659343767835003491.b4-ty@ellerman.id.au \
--to=patch-notifications@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).