From: Paul Mackerras <paulus@samba.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc
Date: Thu, 18 Jun 2009 09:22:18 +1000 [thread overview]
Message-ID: <19001.31402.236289.767105@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <A731338A-E954-46D9-8BF7-6E74C797209C@kernel.crashing.org>
Kumar Gala writes:
> On Jun 17, 2009, at 6:50 AM, Paul Mackerras wrote:
> > +config PPC_HAVE_PMU_SUPPORT
> > + bool
>
> what does this mean?
At the moment it means that arch/powerpc/kernel/perf_counters.c works
for at least some processors in the selected processor family.
> > +
> > +config PPC_PERF_CTRS
> > + def_bool y
> > + depends on PERF_COUNTERS && PPC_HAVE_PMU_SUPPORT
> > + help
> > + This enables the powerpc-specific perf_counter back-end.
>
> Can we distinguish between the two different architected perf counters
> programming models to start with. Maybe something like:
>
> PPC_BOOK3S_PERF_CTRS and PPC_BOOK3E_PERF_CTRS (or
> PPC_SERVER_PERF_CTRS / PPC_EMB_PERF_CTRS)
We can do that once we have code to support the Freescale embedded PMU
and we know how much of arch/powerpc/kernel/perf_counters.c is or
isn't useful there. We don't have to get to the final state in one
patch. I'd rather put this patch in as-is and then see a patch series
that adds the Freescale embedded PMU support and makes whatever
Kconfig changes are necessary later.
Paul.
next prev parent reply other threads:[~2009-06-17 23:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 11:50 [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc Paul Mackerras
2009-06-17 11:51 ` [PATCH 2/6] perf_counter: powerpc: Use unsigned long for register and constraint values Paul Mackerras
2009-06-17 11:52 ` [PATCH 3/6] perf_counter: powerpc: Change how processor-specific back-ends get selected Paul Mackerras
2009-06-17 11:53 ` [PATCH 4/6] perf_counter: powerpc: Make powerpc perf_counter code safe for 32-bit kernels Paul Mackerras
2009-06-17 11:53 ` [PATCH 5/6] perf_counter: powerpc: Add processor back-end for MPC7450 family Paul Mackerras
2009-06-17 14:14 ` Kumar Gala
2009-06-17 23:24 ` Paul Mackerras
2009-06-18 12:50 ` Kumar Gala
2009-06-18 21:10 ` Paul Mackerras
2009-06-17 11:54 ` [PATCH 6/6] perf_counter: tools: Makefile tweaks for 64-bit powerpc Paul Mackerras
2009-06-17 12:08 ` Ingo Molnar
2009-06-17 12:27 ` Paul Mackerras
2009-06-17 13:28 ` Ingo Molnar
2009-06-18 9:13 ` Ingo Molnar
2009-06-19 8:16 ` Paul Mackerras
2009-06-19 16:27 ` Ingo Molnar
2009-06-17 12:04 ` [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc Ingo Molnar
2009-06-17 14:10 ` Kumar Gala
2009-06-17 23:22 ` Paul Mackerras [this message]
2009-06-17 14:21 ` Ingo Molnar
2009-06-17 14:24 ` Kumar Gala
2009-06-17 14:27 ` Ingo Molnar
2009-06-18 23:03 ` Benjamin Herrenschmidt
2009-06-20 10:32 ` Ingo Molnar
2009-06-17 23:27 ` Paul Mackerras
2009-06-18 9:04 ` Ingo Molnar
2009-06-18 23:01 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19001.31402.236289.767105@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=a.p.zijlstra@chello.nl \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).