From: Greg Kroah-Hartman <gregkh@google.com>
To: youling 257 <youling257@gmail.com>, Takashi Iwai <tiwai@suse.de>
Cc: linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
Vladimir Murzin <vladimir.murzin@arm.com>,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org,
Robin Murphy <robin.murphy@arm.com>, Helge Deller <deller@gmx.de>,
x86@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org,
hch@lst.de, linux-arm-kernel@lists.infradead.org
Subject: Re: ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*
Date: Mon, 4 Nov 2019 09:49:43 +0100 [thread overview]
Message-ID: <19c3f0ca-9b21-0c5e-894d-976594f38a86@google.com> (raw)
In-Reply-To: <60ee349a-1fe7-46f0-5161-1dcfcb6fbee9@google.com>
On 11/4/19 9:32 AM, Greg Kroah-Hartman wrote:
> On 11/4/19 9:27 AM, youling 257 wrote:
> > This driver
>
https://android.googlesource.com/kernel/common/+/refs/heads/android-mainline/drivers/usb/gadget/function/f_audio_source.c
>
> >
>
> The driver is broken and needs to be fixed. Please feel free to submit
> patches to AOSP to do so as you can trigger this easily.
Hm, maybe the driver isn't broken...
snd_pcm_lib_preallocate_pages_for_all() is called with
SNDRV_DMA_TYPE_DEV set, so that should be fine, and the only other
buffer I can see allocate here is with a call to
snd_pcm_lib_alloc_vmalloc_buffer() which _should_ be ok, right?
I don't see any buffers coming off the stack here, unless the gadget
controller is the one creating them?
thanks,
greg k-h
next prev parent reply other threads:[~2019-11-05 1:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 7:06 ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_* youling 257
2019-11-04 8:02 ` Takashi Iwai
2019-11-04 8:27 ` youling 257
2019-11-04 8:32 ` Greg Kroah-Hartman
2019-11-04 8:49 ` Greg Kroah-Hartman [this message]
2019-11-04 9:03 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2019-08-08 16:00 [PATCH 5/8] " Christoph Hellwig
2019-11-04 7:26 ` youling257
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19c3f0ca-9b21-0c5e-894d-976594f38a86@google.com \
--to=gregkh@google.com \
--cc=deller@gmx.de \
--cc=hch@lst.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=monstr@monstr.eu \
--cc=robin.murphy@arm.com \
--cc=tiwai@suse.de \
--cc=vladimir.murzin@arm.com \
--cc=x86@kernel.org \
--cc=youling257@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).