From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
To: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"leoyang.li@nxp.com" <leoyang.li@nxp.com>,
"roy.pledge@nxp.com" <roy.pledge@nxp.com>
Cc: "laurentiu.tudor@nxp.com" <laurentiu.tudor@nxp.com>,
"madalin.bucur@nxp.com" <madalin.bucur@nxp.com>
Subject: Re: [PATCH v1 4/8] soc/fsl/qbman: Use index when accessing device tree properties
Date: Mon, 13 May 2019 16:40:36 +0000 [thread overview]
Message-ID: <1afd837287cebccfc1dd68365870d0f5d1cf27f7.camel@infinera.com> (raw)
In-Reply-To: <1557763756-24118-5-git-send-email-roy.pledge@nxp.com>
On Mon, 2019-05-13 at 16:09 +0000, Roy Pledge wrote:
>
> The index value should be passed to the of_parse_phandle()
> function to ensure the correct property is read.
Is this a bug fix? Maybe for stable too?
Jocke
>
> Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
> ---
> drivers/soc/fsl/qbman/dpaa_sys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/qbman/dpaa_sys.c b/drivers/soc/fsl/qbman/dpaa_sys.c
> index 3e0a7f3..0b901a8 100644
> --- a/drivers/soc/fsl/qbman/dpaa_sys.c
> +++ b/drivers/soc/fsl/qbman/dpaa_sys.c
> @@ -49,7 +49,7 @@ int qbman_init_private_mem(struct device *dev, int idx, dma_addr_t *addr,
> idx, ret);
> return -ENODEV;
> }
> - mem_node = of_parse_phandle(dev->of_node, "memory-region", 0);
> + mem_node = of_parse_phandle(dev->of_node, "memory-region", idx);
> if (mem_node) {
> ret = of_property_read_u64(mem_node, "size", &size64);
> if (ret) {
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-05-13 16:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 16:09 [PATCH v1 0/8] soc/fsl/qbman: Enable Kexec for DPAA1 devices Roy Pledge
2019-05-13 16:09 ` [PATCH v1 1/8] soc/fsl/qbman: Rework QBMan private memory setup Roy Pledge
2019-05-13 16:09 ` [PATCH v1 2/8] soc/fsl/qbman: Cleanup buffer pools if BMan was initialized prior to bootup Roy Pledge
2019-05-13 16:09 ` [PATCH v1 3/8] soc/fsl/qbman: Cleanup QMan queues if device was already initialized Roy Pledge
2019-05-13 16:09 ` [PATCH v1 4/8] soc/fsl/qbman: Use index when accessing device tree properties Roy Pledge
2019-05-13 16:40 ` Joakim Tjernlund [this message]
2019-05-13 17:40 ` Roy Pledge
2019-05-14 4:51 ` Joakim Tjernlund
2019-05-13 16:09 ` [PATCH v1 5/8] soc/fsl/qbman: Fix drain_mr_fqni() Roy Pledge
2019-05-13 16:09 ` [PATCH v1 6/8] soc/fsl/qbman: Disable interrupts during portal recovery Roy Pledge
2019-05-13 16:09 ` [PATCH v1 7/8] soc/fsl/qbman: Fixup qman_shutdown_fq() Roy Pledge
2019-05-13 16:09 ` [PATCH v1 8/8] soc/fsl/qbman: Update device tree with reserved memory Roy Pledge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1afd837287cebccfc1dd68365870d0f5d1cf27f7.camel@infinera.com \
--to=joakim.tjernlund@infinera.com \
--cc=laurentiu.tudor@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@nxp.com \
--cc=roy.pledge@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).