From: "Cédric Le Goater" <clg@kaod.org>
To: Sachin Sant <sachinp@linux.ibm.com>, <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH]powerpc/xive: Export XIVE IPI information for online-only processors.
Date: Thu, 6 Jan 2022 18:36:26 +0100 [thread overview]
Message-ID: <1ea0edd7-8450-fb09-32d2-7e7c00c4aa4b@kaod.org> (raw)
In-Reply-To: <164146703333.19039.10920919226094771665.sendpatchset@MacBook-Pro.local>
On 1/6/22 12:03, Sachin Sant wrote:
> Cédric pointed out that XIVE IPI information exported via sysfs
> (debug/powerpc/xive) display empty lines for processors which are
> not online.
>
> Switch to using for_each_online_cpu() so that information is
> displayed for online-only processors.
>
> Reported-by: Cédric Le Goater <clg@kaod.org>
> Signed-off-by: Sachin Sant <sachinp@linux.ibm.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> diff -Naurp a/arch/p werpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c
> --- a/arch/powerpc/sysdev/xive/common.c 2022-01-05 08:52:59.460118219 -0500
> +++ b/arch/powerpc/sysdev/xive/common.c 2022-01-06 02:34:20.994513145 -0500
> @@ -1791,7 +1791,7 @@ static int xive_ipi_debug_show(struct se
> if (xive_ops->debug_show)
> xive_ops->debug_show(m, private);
>
> - for_each_possible_cpu(cpu)
> + for_each_online_cpu(cpu)
> xive_debug_show_ipi(m, cpu);
> return 0;
> }
>
next prev parent reply other threads:[~2022-01-06 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 11:03 [PATCH]powerpc/xive: Export XIVE IPI information for online-only processors Sachin Sant
2022-01-06 17:36 ` Cédric Le Goater [this message]
2022-02-15 5:26 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ea0edd7-8450-fb09-32d2-7e7c00c4aa4b@kaod.org \
--to=clg@kaod.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sachinp@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).