From: Hoang-Nam Nguyen <hnguyen@linux.vnet.ibm.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
raisch@de.ibm.com, general@lists.openfabrics.org,
micfaath@de.ibm.com, stefan.roscher@de.ibm.com
Subject: Re: [PATCH 1/1] IB/ehca: Disallow creating UC QP with SRQ
Date: Mon, 13 Oct 2008 09:34:09 +0200 [thread overview]
Message-ID: <200810130934.09592.hnguyen@linux.vnet.ibm.com> (raw)
In-Reply-To: <adazllcku0c.fsf@cisco.com>
Hi Roland,
That looks good to me.
Thanks for all help.
Nam
On Friday 10 October 2008 23:41, Roland Dreier wrote:
> thanks, applied -- it didn't apply to the latest tree, because of the
> flush CQE changes, so I merged it manually as below -- let me know if
> this is wrong:
>
> commit 0540bbbe455e123a1692d26205ad1a29983883b0
> Author: Hoang-Nam Nguyen <hnguyen@linux.vnet.ibm.com>
> Date: Fri Oct 10 14:40:39 2008 -0700
>
> IB/ehca: Don't allow creating UC QP with SRQ
>
> This patch prevents a UC QP to be created attached to an SRQ, since
> current firmware does not support this feature.
>
> Signed-off-by: Michael Faath <micfaath@de.ibm.com>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
>
> diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c b/drivers/infiniband/hw/ehca/ehca_qp.c
> index 4dbe287..40b578d 100644
> --- a/drivers/infiniband/hw/ehca/ehca_qp.c
> +++ b/drivers/infiniband/hw/ehca/ehca_qp.c
> @@ -502,6 +502,12 @@ static struct ehca_qp *internal_create_qp(
> if (init_attr->srq) {
> my_srq = container_of(init_attr->srq, struct ehca_qp, ib_srq);
>
> + if (qp_type == IB_QPT_UC) {
> + ehca_err(pd->device, "UC with SRQ not supported");
> + atomic_dec(&shca->num_qps);
> + return ERR_PTR(-EINVAL);
> + }
> +
> has_srq = 1;
> parms.ext_type = EQPT_SRQBASE;
> parms.srq_qpn = my_srq->real_qp_num;
>
prev parent reply other threads:[~2008-10-13 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 11:06 [PATCH 1/1] IB/ehca: Disallow creating UC QP with SRQ Hoang-Nam Nguyen
2008-10-10 21:41 ` Roland Dreier
2008-10-13 7:34 ` Hoang-Nam Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810130934.09592.hnguyen@linux.vnet.ibm.com \
--to=hnguyen@linux.vnet.ibm.com \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=micfaath@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=rdreier@cisco.com \
--cc=stefan.roscher@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).