From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org, David,
Gibson <david@gibson.dropbear.id.au>,
Hollis Blanchard <hollis@penguinppc.org>
Subject: Re: 44x _tlbie() ME/CE/DE disabling unnecessary?
Date: Thu, 30 Oct 2008 16:36:45 -0400 [thread overview]
Message-ID: <20081030163645.4385a67c@zod.rchland.ibm.com> (raw)
In-Reply-To: <1225397640.8004.171.camel@pasglop>
On Fri, 31 Oct 2008 07:14:00 +1100
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Thu, 2008-10-30 at 13:04 -0500, Hollis Blanchard wrote:
> >
> > I don't think it's necessary at all to disable ME/CE/DE inside
> > _tlbie() on 440, because the interrupt handlers for those types save
> > and restore MMUCR (they're all the same code path; see
> > mcheck_transfer_to_handler in entry_32.S).
>
> This was written before the saving of MMUCR was added I think.
I was thinking that but git was being annoying.
> > However, I think EE does need to be disabled, since the normal EE
> > handler doesn't deal with MMUCR. So instead of all these MSR
> > manipulations, I think a simple wrteei 0/1 pair should do the trick?
> > Or maybe mfmsr/wrteei/wrtee, in case _tlbie() happens to be called
> > with interrupts disabled already.
>
> Yes.
Agreed. Hollis and I had this discussion on IRC and I pointed out that
the patch originally just started with wrteei's.
(And aren't you supposed to be on vacation...)
josh
next prev parent reply other threads:[~2008-10-30 20:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 18:04 44x _tlbie() ME/CE/DE disabling unnecessary? Hollis Blanchard
2008-10-30 20:14 ` Benjamin Herrenschmidt
2008-10-30 20:36 ` Josh Boyer [this message]
2008-10-30 21:20 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030163645.4385a67c@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=hollis@penguinppc.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).