From: David Gibson <david@gibson.dropbear.id.au>
To: Michael Barkowski <michael.barkowski@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] mpc832x_rdb: fix swapped ethernet ids
Date: Tue, 18 Nov 2008 11:17:40 +1100 [thread overview]
Message-ID: <20081118001740.GA26336@yookeroo.seuss> (raw)
In-Reply-To: <49219BC4.7050803@freescale.com>
On Mon, Nov 17, 2008 at 11:28:52AM -0500, Michael Barkowski wrote:
> David Gibson wrote:
>> On Fri, Nov 14, 2008 at 10:16:19AM -0500, Michael Barkowski wrote:
>>> David Gibson wrote:
>>>> On Thu, Nov 13, 2008 at 10:18:28AM -0500, Michael Barkowski wrote:
>>>>> ethernet0 (called FSL UEC0 in U-Boot) should be enet1 (UCC3/eth1), and
>>>>> ethernet1 should be enet0 (UCC2/eth0), to be consistent with U-Boot so
>>>>> that the interfaces do not swap addresses when control passes from
>>>>> U-Boot to the kernel.
>>>> Um.. why is just swapping the aliases, rather than the enet labels the
>>>> right approach here?
>>> Kim suggested it was better to localize the port ordering as a
>>> property of the board rather than that of the QE, and I agreed.
>>
>> And the enet0/enet1 names that appear in the labels come from the QE
>> documentation?
>>
> No.. but don't you think the UCC2, UCC3 names, which *do* come from
> the QE documentation, should match their labels in numeric ordering?
> Aren't the aliases just machine-specific shortcuts for the
> bootloader?
Ok, that's reasonable (although personally I would have thought it
would make more sense for the labels to be based on the documentation
terms, so UCC2, UCC3 etc., as we do on 4xx).
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2008-11-18 0:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 15:18 [PATCH] mpc832x_rdb: fix swapped ethernet ids Michael Barkowski
2008-11-13 23:45 ` David Gibson
2008-11-14 15:16 ` Michael Barkowski
2008-11-15 2:26 ` David Gibson
2008-11-17 16:28 ` Michael Barkowski
2008-11-18 0:17 ` David Gibson [this message]
2008-11-18 15:02 ` Michael Barkowski
2008-11-19 21:10 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081118001740.GA26336@yookeroo.seuss \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael.barkowski@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).