From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Timur Tabi <timur@freescale.com>
Subject: Re: [PATCH] powerpc/83xx: Fix few build errors with CONFIG_QUICC_ENGINE=n
Date: Tue, 16 Dec 2008 21:44:51 +0300 [thread overview]
Message-ID: <20081216184451.GA6959@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <6C14C18C-D709-4E69-8B47-C8A13380D713@kernel.crashing.org>
On Tue, Dec 16, 2008 at 12:18:07PM -0600, Kumar Gala wrote:
[..]
>> This patch implements traditional way of !QE case handling.
>> Alternative version is coming (w/o ifdefs in the board files).
>>
>> p.s. I don't know if it is 2.6.28 material...
>
> what's the state of this patch vs the alternate version?
Pros of the alternative version:
- No #ifdefs in .c files.
Cons of the alternative version:
- For this code (assuming QE=n):
if ((np = of_find_node_by_name(NULL, "par_io")) != NULL)
par_io_init(np);
GCC can still issue the of_find_node_by_name() call. (I wonder if
there is any way to tell gcc that particular function doesn't
produce any side-effects so that gcc can optimize it away too).
It's up to you to decide which version you want to merge.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-12-16 18:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 16:55 [PATCH] powerpc/83xx: Fix few build errors with CONFIG_QUICC_ENGINE=n Anton Vorontsov
2008-12-05 16:59 ` [PATCH] powerpc/qe: " Anton Vorontsov
2008-12-30 17:19 ` Kumar Gala
2008-12-05 17:09 ` [PATCH] powerpc/83xx: " Kumar Gala
2008-12-05 17:14 ` Timur Tabi
2008-12-16 18:18 ` Kumar Gala
2008-12-16 18:44 ` Anton Vorontsov [this message]
2008-12-16 19:00 ` Scott Wood
2008-12-16 19:14 ` Anton Vorontsov
2008-12-16 22:57 ` Kumar Gala
2008-12-22 17:12 ` Anton Vorontsov
2008-12-30 17:19 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081216184451.GA6959@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).