Re: [PATCH v5] spi: Add PPC4xx SPI driver

From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Brownell <david-b@pacbell.net>
Cc: linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>,
	spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH v5] spi: Add PPC4xx SPI driver
Date: Sun, 28 Dec 2008 08:36:55 +1100	[thread overview]
Message-ID: <20081228083655.0a59d6de.sfr@canb.auug.org.au> (raw)
In-Reply-To: <200812271132.25468.david-b@pacbell.net>

[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]

Hi David, Stefan,

On Sat, 27 Dec 2008 11:32:25 -0800 David Brownell <david-b@pacbell.net> wrote:
>
> Also:
> 
> > +static struct of_platform_driver spi_ppc4xx_of_driver = {
> > +       .owner = THIS_MODULE,
> > +       .name = DRIVER_NAME,
> 
> I'd hope the PPC folk eliminate this duplication soonish.
> Those fields are obvious duplicates of the driver model
> fields...

We are on the path (have been for some time).  Only the driver model
versions should be filled in for new drivers.  For old drivers we copy
the values into the driver model fields if they are not already set.  We
intend to remove the of_platform_drivers versions of "name" and "owner"
soon.

> > +       .match_table = spi_ppc4xx_of_match,
> > +       .probe = spi_ppc4xx_of_probe,
> > +       .remove = __exit_p(spi_ppc4xx_of_remove),
> > +       .driver = {
> > +               .name = DRIVER_NAME,
> > +               .owner = THIS_MODULE,
> > +       },
> > +};
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]