From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-ppc <linuxppc-dev@ozlabs.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Milton Miller <miltonm@bga.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH
Date: Tue, 6 Jan 2009 21:27:24 +0530 [thread overview]
Message-ID: <20090106155724.GA6747@linux.vnet.ibm.com> (raw)
In-Reply-To: <20090106104619.GA13789@uranus.ravnborg.org>
* Sam Ravnborg <sam@ravnborg.org> [2009-01-06 11:46:19]:
> Hi Kamalesh
>
> Looks good, small nit below.
>
> > config VIOPATH
> > bool
> > - depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH
> > - default y
> > + default n
>
> As 'n' is default anyway this line is not needed and I suggest you
> spin a final version of the patch with this removed.
>
> Sam
Hi Sam,
Thanks for the review comments. I am resending the patch with the changes
you have recommended.
Impact: Fix the VIOPATH dependency in the iSeries dependent drivers.
iSeries depend drivers build fails, when CONFIG_VIOPATH is disabled.
Removing the dependency of VIOPATH by selecting it, when the drivers
dependent on iSeries code.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
---
arch/powerpc/platforms/iseries/Kconfig | 5 +++--
drivers/char/Kconfig | 1 +
drivers/scsi/Kconfig | 1 +
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/iseries/Kconfig b/arch/powerpc/platforms/iseries/Kconfig
index ed3753d..7ddd0a2 100644
--- a/arch/powerpc/platforms/iseries/Kconfig
+++ b/arch/powerpc/platforms/iseries/Kconfig
@@ -10,18 +10,21 @@ menu "iSeries device drivers"
config VIODASD
tristate "iSeries Virtual I/O disk support"
depends on BLOCK
+ select VIOPATH
help
If you are running on an iSeries system and you want to use
virtual disks created and managed by OS/400, say Y.
config VIOCD
tristate "iSeries Virtual I/O CD support"
+ select VIOPATH
help
If you are running Linux on an IBM iSeries system and you want to
read a CD drive owned by OS/400, say Y here.
config VIOTAPE
tristate "iSeries Virtual Tape Support"
+ select VIOPATH
help
If you are running Linux on an iSeries system and you want Linux
to read and/or write a tape drive owned by OS/400, say Y here.
@@ -30,5 +33,3 @@ endmenu
config VIOPATH
bool
- depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH
- default y
diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 1697043..b8da09a 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -616,6 +616,7 @@ config HVC_ISERIES
default y
select HVC_DRIVER
select HVC_IRQ
+ select VIOPATH
help
iSeries machines support a hypervisor virtual console.
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index b732297..256c7be 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -884,6 +884,7 @@ config SCSI_IBMVSCSI
tristate "IBM Virtual SCSI support"
depends on PPC_PSERIES || PPC_ISERIES
select SCSI_SRP_ATTRS
+ select VIOPATH if PPC_ISERIES
help
This is the IBM POWER Virtual SCSI Client
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
next prev parent reply other threads:[~2009-01-06 15:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 8:54 [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH Milton Miller
2009-01-04 12:12 ` Stephen Rothwell
2009-01-04 18:24 ` Kamalesh Babulal
2009-01-05 13:33 ` Milton Miller
2009-01-06 7:25 ` Kamalesh Babulal
2009-01-06 7:31 ` Sam Ravnborg
2009-01-06 9:38 ` Kamalesh Babulal
2009-01-06 10:46 ` Sam Ravnborg
2009-01-06 15:57 ` Kamalesh Babulal [this message]
2009-01-06 16:40 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2009-01-03 19:13 Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106155724.GA6747@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).