From: Chandru <chandru@in.ibm.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.28-rc9 panics with crashkernel=256M while booting
Date: Thu, 8 Jan 2009 15:59:21 +0530 [thread overview]
Message-ID: <200901081559.22204.chandru@in.ibm.com> (raw)
In-Reply-To: <1231349125.23462.81.camel@nimitz>
On Wednesday 07 January 2009 22:55:25 Dave Hansen wrote:
>
> I'm just suggesting making your fix in the ppc code instead of in
> mm/bootmem.c.
>
Here are the changes that helped to boot the kernel. Please review it.
Thanks,
Signed-off-by: Chandru S <chandru@linux.vnet.ibm.com>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>
---
arch/powerpc/mm/numa.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
--- linux-2.6.28/arch/powerpc/mm/numa.c.orig 2009-01-08 03:20:41.000000000 -0600
+++ linux-2.6.28/arch/powerpc/mm/numa.c 2009-01-08 03:50:41.000000000 -0600
@@ -16,6 +16,7 @@
#include <linux/module.h>
#include <linux/nodemask.h>
#include <linux/cpu.h>
+#include <linux/pfn.h>
#include <linux/notifier.h>
#include <linux/lmb.h>
#include <linux/of.h>
@@ -898,9 +899,17 @@ static void mark_reserved_regions_for_ni
* if reserved region extends past active region
* then trim size to active region
*/
- if (end_pfn > node_ar.end_pfn)
+ if (end_pfn > node_ar.end_pfn) {
reserve_size = (node_ar.end_pfn << PAGE_SHIFT)
- (start_pfn << PAGE_SHIFT);
+ /*
+ * resize it further if the reservation could
+ * cross the last page in this node
+ */
+ if (PFN_UP(physbase+reserve_size) >
+ node_end_pfn)
+ reserve_size -= PAGE_SIZE;
+ }
/*
* Only worry about *this* node, others may not
* yet have valid NODE_DATA().
next prev parent reply other threads:[~2009-01-08 10:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200812241325.49404.chandru@in.ibm.com>
2008-12-25 7:35 ` 2.6.28-rc9 panics with crashkernel=256M while booting Andrew Morton
2008-12-25 8:07 ` Andrew Morton
2008-12-26 0:59 ` Paul Mackerras
2008-12-29 21:36 ` Dave Hansen
2009-01-05 13:49 ` Chandru
2009-01-05 16:30 ` Dave Hansen
2009-01-07 12:58 ` Chandru
2009-01-07 17:25 ` Dave Hansen
2009-01-08 10:29 ` Chandru [this message]
2009-01-08 20:03 ` Dave Hansen
2009-01-09 11:07 ` Chandru
2009-01-15 8:05 ` Chandru
2009-01-16 12:16 ` Chandru
2009-01-16 17:52 ` Dave Hansen
2009-01-19 8:11 ` Chandru
2009-01-19 11:30 ` Chandru
2009-01-20 8:13 ` Chandru
2009-01-22 0:29 ` Dave Hansen
2009-01-22 8:20 ` Chandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901081559.22204.chandru@in.ibm.com \
--to=chandru@in.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).