From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, jgarzik@pobox.com,
afleming@freescale.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] net: make mpc5200 fec driver use of_mdio infrastructure
Date: Tue, 10 Mar 2009 22:16:38 +0300 [thread overview]
Message-ID: <20090310191638.GA8539@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090310152224.12455.99348.stgit@localhost.localdomain>
On Tue, Mar 10, 2009 at 09:22:24AM -0600, Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
[...]
> +static int mpc52xx_fec_notifier_phy_add(struct notifier_block *nb,
> + unsigned long event, void *_dev)
> +{
[...]
> + rc = phy_connect_direct(priv->ndev, priv->phydev,
> + mpc52xx_fec_adjust_link, 0, 0);
> + if (rc) {
> + dev_err(dev, "phy_connect_direct() failed\n");
> + return 0;
> + }
> +
> + rc = register_netdev(priv->ndev);
> + if (rc) {
> + phy_disconnect(priv->phydev);
> + dev_err(dev, "register_netdev() failed\n");
> + }
> +
> + return 0;
> +}
[...]
> static int __devinit
> mpc52xx_fec_probe(struct of_device *op, const struct of_device_id *match)
> @@ -896,7 +874,6 @@ mpc52xx_fec_probe(struct of_device *op, const struct of_device_id *match)
[...]
> + /* Register the new network device immediately if we don't need
> + * to wait for a phy_device first. */
> + if (!priv->phy_node) {
> + if (priv->seven_wire_mode)
> + dev_info(&ndev->dev, "using 7-wire PHY mode\n");
> + else
> + dev_info(&ndev->dev, "Fixed speed MII link: %i%cD\n",
> + priv->speed, priv->duplex ? 'F' : 'H');
> + rv = register_netdev(ndev);
> + if (rv < 0)
> + goto probe_error;
> }
[...]
Two registration points for the netdev... That's ugly. :-/
What problem are you trying to solve w/ these patches, btw?
`ifconfig ethX up` is safe even w/o PHY attached.
All the (user-visible) changes is that we no longer have "ethX"
until PHY is registered, and I can't say that this is good either.
Previously you'd have ethX all the time, and `ifconfig ethX up`
would report user-friendly "PHY not attached" error. Now we have
to guess why ethX isn't there.
I can't say that the probing code is much prettier or easier to
understand... But maybe there are some other problems that you're
solving, which I don't see so far?
That is, can you explain why the changes are needed? Did you
consider other solutions?
Thanks!
p.s.
> eliminates the assumption that the PHY for the FEC is always
> attached to the FEC's own MDIO bus. With this patch, the FEC can
> use a PHY attached to any MDIO bus if it is described in the device
> tree.
AFAIK, Gianfar and UCC Geth drivers can do this too, so I'm assuming
that this isn't the cause for these major changes.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-03-10 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 15:21 [PATCH 0/5] Retrieving Ethernet PHY wireup from the OF device tree Grant Likely
2009-03-10 15:22 ` [PATCH 1/5] drivers/base: Add bus_register_notifier_alldev() variant Grant Likely
2009-03-10 15:22 ` [PATCH 2/5] phylib: rework to prepare for OF registration of PHYs Grant Likely
2009-03-10 15:22 ` [PATCH 3/5] phylib: add *_direct() variants of phy_connect and phy_attach functions Grant Likely
2009-03-10 15:22 ` [PATCH 4/5] openfirmware: Add OF phylib support code Grant Likely
2009-03-10 15:22 ` [PATCH 5/5] net: make mpc5200 fec driver use of_mdio infrastructure Grant Likely
2009-03-10 19:16 ` Anton Vorontsov [this message]
2009-03-10 19:48 ` Grant Likely
2009-03-10 20:29 ` Anton Vorontsov
2009-03-19 4:35 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090310191638.GA8539@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=afleming@freescale.com \
--cc=grant.likely@secretlab.ca \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).