From: David Miller <davem@davemloft.net>
To: avorontsov@ru.mvista.com
Cc: netdev@vger.kernel.org, leoli@freescale.com,
Joakim.Tjernlund@transmode.se, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ucc_geth: Fix three oopses in PHY {de,}initialization code
Date: Fri, 27 Mar 2009 16:00:29 -0700 (PDT) [thread overview]
Message-ID: <20090327.160029.157396274.davem@davemloft.net> (raw)
In-Reply-To: <20090327174047.GA23111@oksana.dev.rtsoft.ru>
From: Anton Vorontsov <avorontsov@ru.mvista.com>
Date: Fri, 27 Mar 2009 20:40:47 +0300
> When there are no free snums, UCC ethernet should gracefully fail, but
> currently it oopses this way:
...
> Also, when device tree specifies fixed-link, and CONFIG_FIXED_PHY
> is disabled, we'll get this oops:
...
> This patch fixes all three oopses simply by rearranging some code:
>
> - In ucc_geth_open(): move init_phy() call to the beginning, so
> that we only call ucc_geth_stop() with a PHY attached;
> - Move phy_disconnect() call from ucc_geth_close() to
> ucc_geth_stop(), so that we'll always disconnect the PHY.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Applied, thanks Anton.
prev parent reply other threads:[~2009-03-27 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 17:40 [PATCH] ucc_geth: Fix three oopses in PHY {de,}initialization code Anton Vorontsov
2009-03-27 23:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327.160029.157396274.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joakim.Tjernlund@transmode.se \
--cc=avorontsov@ru.mvista.com \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).