From: Grant Likely <grant.likely@secretlab.ca>
To: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org,
David Miller <davem@davemloft.net>
Subject: [PATCH] net/fec_mpc52xx: fix BUG on missing dma_ops
Date: Mon, 30 Mar 2009 12:53:14 -0600 [thread overview]
Message-ID: <20090330184423.31699.61150.stgit@localhost.localdomain> (raw)
From: Grant Likely <grant.likely@secretlab.ca>
The driver triggers a BUG_ON() when allocating DMA buffers if the
arch/powerpc dma_ops from the of_platform device are not copied
into net_device structure.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
David, do you want to pick this one up right away, or should I merge it
through Ben's powerpc tree?
g.
drivers/net/fec_mpc52xx.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c
index 049b0a7..215207d 100644
--- a/drivers/net/fec_mpc52xx.c
+++ b/drivers/net/fec_mpc52xx.c
@@ -928,6 +928,9 @@ mpc52xx_fec_probe(struct of_device *op, const struct of_device_id *match)
if (!request_mem_region(mem.start, sizeof(struct mpc52xx_fec), DRIVER_NAME))
return -EBUSY;
+ /* Copy the PowerPC dma_ops from the of_device */
+ set_dma_ops(&ndev->dev, get_dma_ops(&op->dev));
+
/* Init ether ndev with what we have */
ndev->open = mpc52xx_fec_open;
ndev->stop = mpc52xx_fec_close;
next reply other threads:[~2009-03-30 18:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 18:53 Grant Likely [this message]
2009-03-30 22:30 ` [PATCH] net/fec_mpc52xx: fix BUG on missing dma_ops Becky Bruce
2009-03-31 2:25 Grant Likely
2009-03-31 18:58 ` Becky Bruce
2009-03-31 19:10 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090330184423.31699.61150.stgit@localhost.localdomain \
--to=grant.likely@secretlab.ca \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).