From: Andrew Morton <akpm@linux-foundation.org>
To: Harry Ciao <qingtao.cao@windriver.com>
Cc: norsk5@yahoo.com, bluesmoke-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [v2 PATCH 1/3] EDAC: Add CPC925 Memory Controller driver
Date: Wed, 15 Apr 2009 15:27:04 -0700 [thread overview]
Message-ID: <20090415152704.b7ebddc7.akpm@linux-foundation.org> (raw)
In-Reply-To: <1239602716-18352-2-git-send-email-qingtao.cao@windriver.com>
On Mon, 13 Apr 2009 14:05:14 +0800
Harry Ciao <qingtao.cao@windriver.com> wrote:
> Introduce IBM CPC925 EDAC driver, which makes use of ECC, CPU and
> HyperTransport Link error detections and corrections on the IBM
> CPC925 Bridge and Memory Controller.
A wee cleanup:
--- a/drivers/edac/cpc925_edac.c~edac-add-cpc925-memory-controller-driver-cleanup
+++ a/drivers/edac/cpc925_edac.c
@@ -291,9 +291,6 @@ struct cpc925_dev_info {
void (*check)(struct edac_device_ctl_info *edac_dev);
};
-
-static int edac_mc_idx;
-
/* Get total memory size from Open Firmware DTB */
static void get_total_mem(struct cpc925_mc_pdata *pdata)
{
@@ -866,6 +863,7 @@ static int cpc925_mc_get_channels(void _
static int __devinit cpc925_probe(struct platform_device *pdev)
{
+ static int edac_mc_idx;
struct mem_ctl_info *mci;
void __iomem *vbase;
struct cpc925_mc_pdata *pdata;
_
next prev parent reply other threads:[~2009-04-15 22:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 6:05 [v2 PATCH 0/3] Add CPC925 Memory Controller EDAC drivers Harry Ciao
2009-04-13 6:05 ` [v2 PATCH 1/3] EDAC: Add CPC925 Memory Controller driver Harry Ciao
2009-04-13 6:05 ` [v2 PATCH 2/3] EDAC: Add edac_device_alloc_index() Harry Ciao
2009-04-13 6:05 ` [v2 PATCH 3/3] EDAC: CPC925 MC platform device setup Harry Ciao
2009-04-15 22:27 ` [v2 PATCH 2/3] EDAC: Add edac_device_alloc_index() Andrew Morton
2009-04-15 22:27 ` Andrew Morton [this message]
2009-04-30 3:08 ` [v2 PATCH 1/3] EDAC: Add CPC925 Memory Controller driver Benjamin Herrenschmidt
2009-04-15 22:26 ` [v2 PATCH 0/3] Add CPC925 Memory Controller EDAC drivers Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090415152704.b7ebddc7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=norsk5@yahoo.com \
--cc=qingtao.cao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).