From: Sam Ravnborg <sam@ravnborg.org>
To: LKML <linux-kernel@vger.kernel.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Wolfgang Denk <wd@denx.de>,
Manuel Lauss <mano@roarinelk.homelinux.net>,
Anders Kaseorg <andersk@mit.edu>,
linuxppc-dev <linuxppc-dev@ozlabs.org>,
Sean MacLennan <smaclennan@pikatech.com>,
Jean Delvare <khali@linux-fr.org>
Subject: [PATCH 2/3] kbuild, modpost: fix "unexpected non-allocatable" warning with SUSE gcc
Date: Mon, 4 May 2009 14:00:25 +0200 [thread overview]
Message-ID: <20090504120025.GB7239@uranus.ravnborg.org> (raw)
In-Reply-To: <20090504115704.GA7134@uranus.ravnborg.org>
>From 028ecebdd83cc4a7f8c7e96e28a5537d2ac98dae Mon Sep 17 00:00:00 2001
From: Sam Ravnborg <sam@ravnborg.org>
Date: Sun, 3 May 2009 22:17:37 +0200
Subject: [PATCH 2/3] kbuild, modpost: fix "unexpected non-allocatable" warning with SUSE gcc
Jean reported that he saw one warning for each module like the one below:
WARNING: arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.o (.comment.SUSE.OPTs): unexpected non-allocatable section.
The warning appeared with the improved version of the
check of the flags in the sections.
That check already ignored sections named ".comment" - but SUSE store
additional info in the comment section and has named it in a SUSE
specific way. Therefore modpost failed to ignore the section.
The fix is to extend the pattern so we ignore all sections
that start with the name ".comment.".
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Reported-by: Jean Delvare <khali@linux-fr.org>
Tested-by: Jean Delvare <khali@linux-fr.org>
---
scripts/mod/modpost.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index a5c17db..268d457 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -727,7 +727,7 @@ int match(const char *sym, const char * const pat[])
/* sections that we do not want to do full section mismatch check on */
static const char *section_white_list[] =
- { ".comment", ".debug*", ".stab*", ".note*", ".got*", ".toc*", NULL };
+ { ".comment*", ".debug*", ".stab*", ".note*", ".got*", ".toc*", NULL };
/*
* This is used to find sections missing the SHF_ALLOC flag.
--
1.6.3.rc3.40.g75b44
next prev parent reply other threads:[~2009-05-04 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 11:57 kbuild, modpost: fix "non-allocatable section" warnings Sam Ravnborg
2009-05-04 11:59 ` [PATCH 1/3] kbuild, modpost: fix unexpected non-allocatable section when cross compiling Sam Ravnborg
2009-05-04 12:00 ` Sam Ravnborg [this message]
2009-05-04 12:01 ` [PATCH 3/3] kbuild, modpost: fix unexpected non-allocatable warning with mips Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504120025.GB7239@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=andersk@mit.edu \
--cc=khali@linux-fr.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mano@roarinelk.homelinux.net \
--cc=sfr@canb.auug.org.au \
--cc=smaclennan@pikatech.com \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).