From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Arun R Bharadwaj <arun@linux.vnet.ibm.com>
Cc: linux-arch@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>,
linuxppc-dev@lists.ozlabs.org,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [v8 PATCH 1/8]: cpuidle: cleanup drivers/cpuidle/cpuidle.c
Date: Mon, 12 Oct 2009 17:06:02 +0530 [thread overview]
Message-ID: <20091012113602.GC3007@balbir.in.ibm.com> (raw)
In-Reply-To: <20091008094942.GB20595@linux.vnet.ibm.com>
* Arun R B <arun@linux.vnet.ibm.com> [2009-10-08 15:19:42]:
> * Arun R Bharadwaj <arun@linux.vnet.ibm.com> [2009-10-08 15:18:28]:
>
> This patch cleans up drivers/cpuidle/cpuidle.c
> Earlier cpuidle assumed pm_idle as the default idle loop. Break that
> assumption and make it more generic. cpuidle_idle_call() which is the
> main idle loop of cpuidle is to be called by architectures which have
> registered to cpuidle.
>
> Remove routines cpuidle_install/uninstall_idle_handler() which are not
> needed anymore.
>
>
[snip]
/**
> - * cpuidle_install_idle_handler - installs the cpuidle idle loop handler
> - */
> -void cpuidle_install_idle_handler(void)
> -{
> - if (enabled_devices && (pm_idle != cpuidle_idle_call)) {
> - /* Make sure all changes finished before we switch to new idle */
> - smp_wmb();
> - pm_idle = cpuidle_idle_call;
> - }
> -}
> -
> -/**
> - * cpuidle_uninstall_idle_handler - uninstalls the cpuidle idle loop handler
> - */
> -void cpuidle_uninstall_idle_handler(void)
> -{
> - if (enabled_devices && pm_idle_old && (pm_idle != pm_idle_old)) {
> - pm_idle = pm_idle_old;
> - cpuidle_kick_cpus();
> - }
> -}
> -
I see the routines above being called in from
cpuidle_pause/resume_and_lock/unlock below and they are entries from
ACPI on ACPI_PROCESSOR_NOTIFY_POWER and from the hotplug path, could
you test them to make sure they are not broken. We also seem to be
missing a cpuidle_kick_cpus() in cpuidle_pause_and_lock()
[snip]
--
Balbir
next prev parent reply other threads:[~2009-10-12 11:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 9:48 [v8 PATCH 0/8]: cpuidle: Cleanup cpuidle/ Introduce cpuidle to POWER Arun R Bharadwaj
2009-10-08 9:49 ` [v8 PATCH 1/8]: cpuidle: cleanup drivers/cpuidle/cpuidle.c Arun R Bharadwaj
2009-10-12 11:36 ` Balbir Singh [this message]
2009-10-14 6:24 ` Arun R Bharadwaj
2009-10-08 9:50 ` [v8 PATCH 2/8]: cpuidle: implement a list based approach to register a set of idle routines Arun R Bharadwaj
2009-10-08 10:36 ` Peter Zijlstra
2009-10-08 10:42 ` Arun R Bharadwaj
2009-10-08 10:50 ` Peter Zijlstra
2009-10-08 11:01 ` Arun R Bharadwaj
2009-10-08 11:25 ` Peter Zijlstra
2009-10-08 12:01 ` Arun R Bharadwaj
2009-10-08 12:25 ` Peter Zijlstra
2009-10-08 13:10 ` Vaidyanathan Srinivasan
2009-10-09 9:39 ` Arun R Bharadwaj
2009-10-12 18:00 ` Andi Kleen
2009-10-14 6:17 ` Arun R Bharadwaj
2009-10-14 7:18 ` Andi Kleen
2009-10-15 6:06 ` Arun R Bharadwaj
2009-10-08 9:51 ` [v8 PATCH 3/8]: x86: refactor x86 idle power management code and remove all instances of pm_idle Arun R Bharadwaj
2009-10-08 9:52 ` [v8 PATCH 4/8]: POWER: enable cpuidle for POWER Arun R Bharadwaj
2009-10-08 9:53 ` [v8 PATCH 5/8]: pSeries/cpuidle: remove dedicate/shared idle loops, which will be moved to arch/powerpc/platforms/pseries/processor_idle.c Arun R Bharadwaj
2009-10-08 9:53 ` [v8 PATCH 6/8]: POWER: add a default_idle idle loop for POWER Arun R Bharadwaj
2009-10-08 9:54 ` [v8 PATCH 7/8]: pSeries: implement pSeries processor idle module Arun R Bharadwaj
2009-10-08 9:56 ` [v8 PATCH 8/8]: POWER: Enable default_idle when power_save=off Arun R Bharadwaj
2009-10-12 10:01 ` [v8 PATCH 0/8]: cpuidle: Cleanup cpuidle/ Introduce cpuidle to POWER Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012113602.GC3007@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@infradead.org \
--cc=arun@linux.vnet.ibm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).