From: akpm@linux-foundation.org
To: benh@kernel.crashing.org
Cc: waite@skycomputers.com, roel.kluin@gmail.com, gorcunov@gmail.com,
linuxppc-dev@ozlabs.org, galak@gate.crashing.org,
akpm@linux-foundation.org
Subject: [patch 1/2] powerpc: Sky CPU: redundant or incorrect tests on unsigned
Date: Tue, 02 Feb 2010 14:40:01 -0800 [thread overview]
Message-ID: <201002022240.o12Me1iY018842@imap1.linux-foundation.org> (raw)
From: Roel Kluin <roel.kluin@gmail.com>
count is unsigned and cannot be less than 0.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Kumar Gala <galak@gate.crashing.org>
Cc: Brian Waite <waite@skycomputers.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/misc/hdpuftrs/hdpu_cpustate.c | 5 -----
1 file changed, 5 deletions(-)
diff -puN drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned drivers/misc/hdpuftrs/hdpu_cpustate.c
--- a/drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned
+++ a/drivers/misc/hdpuftrs/hdpu_cpustate.c
@@ -121,8 +121,6 @@ static ssize_t cpustate_read(struct file
{
unsigned char data;
- if (count < 0)
- return -EFAULT;
if (count == 0)
return 0;
@@ -137,9 +135,6 @@ static ssize_t cpustate_write(struct fil
{
unsigned char data;
- if (count < 0)
- return -EFAULT;
-
if (count == 0)
return 0;
_
next reply other threads:[~2010-02-02 22:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 22:40 akpm [this message]
2010-02-03 23:21 ` [patch 1/2] powerpc: Sky CPU: redundant or incorrect tests on unsigned Benjamin Herrenschmidt
2010-02-04 0:10 ` support
2010-02-04 0:18 ` Benjamin Herrenschmidt
2010-02-04 1:47 ` support
2010-02-04 2:01 ` Benjamin Herrenschmidt
2010-02-04 12:38 ` Sky Support
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002022240.o12Me1iY018842@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=galak@gate.crashing.org \
--cc=gorcunov@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=roel.kluin@gmail.com \
--cc=waite@skycomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).