From: Sean MacLennan <smaclennan@pikatech.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: [PATCH] powerpc: fix .data..init_task output section
Date: Thu, 22 Jul 2010 19:50:08 -0400 [thread overview]
Message-ID: <20100722195008.72fe2e71@lappy.seanm.ca> (raw)
In-Reply-To: <20100713095024.GA10494@merkur.ravnborg.org>
On Tue, 13 Jul 2010 11:50:24 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> From 851e645a7eee68380caaf026eb6d3be118876370 Mon Sep 17 00:00:00 2001
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Tue, 13 Jul 2010 11:39:42 +0200
> Subject: [PATCH] vmlinux.lds: fix .data..init_task output section
> (fix popwerpc boot)
>
> The .data..init_task output section was missing
> a load offset causing a popwerpc target to fail to boot.
>
> Sean MacLennan tracked it down to the definition of
> INIT_TASK_DATA_SECTION().
>
> There are only two users of INIT_TASK_DATA_SECTION()
> in the kernel today: cris and popwerpc.
> cris do not support relocatable kernels and is thus not
> impacted by this change.
>
> Fix INIT_TASK_DATA_SECTION() to specify load offset like
> all other output sections.
>
> Reported-by: Sean MacLennan <smaclennan@pikatech.com>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>
> On the assumption that Sean reports that it fixes
> the warnings/boot issue here is a real patch.
>
> Ben - will you take it via the popwerpc tree
> or shall I ask Michal to take it via kbuild?
>
> Sam
>
> include/asm-generic/vmlinux.lds.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h
> b/include/asm-generic/vmlinux.lds.h index 48c5299..cdfff74 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -435,7 +435,7 @@
> */
> #define
> INIT_TASK_DATA_SECTION(align)
> \ . = ALIGN(align); \
> - .data..init_task :
> { \
> + .data..init_task : AT(ADDR(.data..init_task) - LOAD_OFFSET)
> { \
> INIT_TASK_DATA(align) \ }
>
next prev parent reply other threads:[~2010-07-22 23:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 4:59 section .data..init_task Sean MacLennan
2010-07-13 0:34 ` Sean MacLennan
2010-07-13 8:54 ` Sam Ravnborg
2010-07-13 15:26 ` Sean MacLennan
2010-07-13 15:33 ` Sam Ravnborg
2010-07-13 9:50 ` [ Sam Ravnborg
2010-07-22 22:27 ` [ Sean MacLennan
2010-07-22 22:33 ` [ Benjamin Herrenschmidt
2010-07-22 23:50 ` Sean MacLennan [this message]
2010-07-23 13:58 ` [PATCH] powerpc: fix .data..init_task output section Sam Ravnborg
2010-07-23 22:16 ` Benjamin Herrenschmidt
2010-07-22 23:55 Sean MacLennan
2010-07-23 0:04 ` Sean MacLennan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100722195008.72fe2e71@lappy.seanm.ca \
--to=smaclennan@pikatech.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).