From: Sergei Poselenov <sposelenov@emcraft.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, wd@denx.de, dzu@denx.de
Subject: Re: [PATCH 1/2] [PPC] Motion-PRO: Added LED support for the Promess Motion-Pro board. The driver is based on the original version(http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg06694.html), adapted for the current kernel structures.
Date: Thu, 2 Sep 2010 17:34:56 +0400 [thread overview]
Message-ID: <20100902173456.3fdef6b8@emcraft.com> (raw)
In-Reply-To: <20100902124617.GA27957@oksana.dev.rtsoft.ru>
Hi Anton,
On Thu, 2 Sep 2010 16:46:17 +0400
Anton Vorontsov <cbouatmailru@gmail.com> wrote:
> On Thu, Sep 02, 2010 at 12:20:31PM +0200, sposelenov@emcraft.com
> wrote: [...]
> > +config LEDS_MOTIONPRO
> > + tristate "Motionpro LEDs Support"
> > + depends on LEDS_CLASS
> > + help
> > + This option enables support for status and ready LEDs
> > connected
> > + to GPIO lines on Motionpro board.
>
> Why not expose these GPIOs via GPIOLIB[1] and use generic GPIO
> LEDs[2] driver, along with the timer LED trigger[3] for blinking?
>
> Thanks,
>
> [1] Documentation/gpio.txt
> Documentation/powerpc/dts-bindings/gpio/gpio.txt
> [2] drivers/leds/leds-gpio.c
> Documentation/powerpc/dts-bindings/gpio/led.txt
> [3] drivers/leds/ledtrig-timer.c
>
Yes, this seem possible to implement (and thanks for pointing into
this), however, the driver is already exists (actually, since 2007),
so why to not add it to save efforts?
Regards,
Sergei
next prev parent reply other threads:[~2010-09-02 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 10:20 [PATCH 1/2] [PPC] Motion-PRO: Added LED support for the Promess Motion-Pro board. The driver is based on the original version(http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg06694.html), adapted for the current kernel structures sposelenov
2010-09-02 10:20 ` [PATCH 2/2] [PPC] Motion-PRO: Changed the default blinking rate for the status LED to 200 ms, as per the customer's request sposelenov
2010-09-02 12:46 ` [PATCH 1/2] [PPC] Motion-PRO: Added LED support for the Promess Motion-Pro board. The driver is based on the original version(http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg06694.html), adapted for the current kernel structures Anton Vorontsov
2010-09-02 13:34 ` Sergei Poselenov [this message]
2010-09-02 14:01 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902173456.3fdef6b8@emcraft.com \
--to=sposelenov@emcraft.com \
--cc=cbouatmailru@gmail.com \
--cc=dzu@denx.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).