From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Nathan Fontenot <nfont@austin.ibm.com>
Cc: Greg KH <greg@kroah.com>,
steiner@sgi.com, linux-kernel@vger.kernel.org,
Dave Hansen <dave@linux.vnet.ibm.com>,
linux-mm@kvack.org, Robin Holt <holt@sgi.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/9] v3 Add section count to memory_block struct
Date: Tue, 5 Oct 2010 14:08:35 +0900 [thread overview]
Message-ID: <20101005140835.9c80c2e7.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <4CA628D0.6030508@austin.ibm.com>
On Fri, 01 Oct 2010 13:30:40 -0500
Nathan Fontenot <nfont@austin.ibm.com> wrote:
> Add a section count property to the memory_block struct to track the number
> of memory sections that have been added/removed from a memory block. This
> allows us to know when the last memory section of a memory block has been
> removed so we can remove the memory block.
>
> Signed-off-by: Nathan Fontenot <nfont@austin.ibm.com>
>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
a nitpick,
> Index: linux-next/include/linux/memory.h
> ===================================================================
> --- linux-next.orig/include/linux/memory.h 2010-09-29 14:56:29.000000000 -0500
> +++ linux-next/include/linux/memory.h 2010-09-30 14:13:50.000000000 -0500
> @@ -23,6 +23,8 @@
> struct memory_block {
> unsigned long phys_index;
> unsigned long state;
> + int section_count;
I prefer
int section_count; /* updated under mutex */
or some for this kind of non-atomic counters. but nitpick.
next prev parent reply other threads:[~2010-10-05 5:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 18:22 [PATCH 0/9] v3 De-couple sysfs memory directories from memory sections Nathan Fontenot
2010-10-01 18:28 ` [PATCH 1/9] v3 Move find_memory_block routine Nathan Fontenot
2010-10-01 18:40 ` Robin Holt
2010-10-05 5:01 ` KAMEZAWA Hiroyuki
2010-10-01 18:29 ` [PATCH 2/9] v3 Add mutex for adding/removing memory blocks Nathan Fontenot
2010-10-01 18:45 ` Robin Holt
2010-10-05 5:06 ` KAMEZAWA Hiroyuki
2010-10-01 18:30 ` [PATCH 3/9] v3 Add section count to memory_block struct Nathan Fontenot
2010-10-01 18:46 ` Robin Holt
2010-10-05 5:08 ` KAMEZAWA Hiroyuki [this message]
2010-10-01 18:31 ` [PATCH 4/9] v3 Allow memory blocks to span multiple memory sections Nathan Fontenot
2010-10-01 18:52 ` Robin Holt
2010-10-01 18:56 ` Nathan Fontenot
2010-10-01 19:00 ` Nathan Fontenot
2010-10-01 19:20 ` Robin Holt
2010-10-05 5:13 ` KAMEZAWA Hiroyuki
2010-10-01 18:33 ` [PATCH 5/9] v3 rename phys_index properties of memory block struct Nathan Fontenot
2010-10-01 18:54 ` Robin Holt
2010-10-05 5:14 ` KAMEZAWA Hiroyuki
2010-10-01 18:34 ` [PATCH 6/9] v3 Update node sysfs code Nathan Fontenot
2010-10-01 18:55 ` Robin Holt
2010-10-05 5:15 ` KAMEZAWA Hiroyuki
2010-10-01 18:35 ` [PATCH 7/9] v3 Define memory_block_size_bytes for powerpc/pseries Nathan Fontenot
2010-10-01 18:56 ` Robin Holt
2010-10-03 17:55 ` Balbir Singh
2010-10-03 18:07 ` Robin Holt
2010-10-03 18:11 ` Dave Hansen
2010-10-03 18:27 ` Balbir Singh
2010-10-04 14:45 ` Nathan Fontenot
2010-10-01 18:37 ` [PATCH 8/9] v3 Define memory_block_size_bytes for x86_64 with CONFIG_X86_UV set Nathan Fontenot
2010-10-01 18:57 ` Robin Holt
2010-10-01 18:37 ` [PATCH 9/9] v3 Update memory hotplug documentation Nathan Fontenot
2010-10-01 18:58 ` Robin Holt
2010-10-05 5:18 ` KAMEZAWA Hiroyuki
2010-10-21 12:05 ` [PATCH 0/9] v3 De-couple sysfs memory directories from memory sections Nikanth Karthikesan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101005140835.9c80c2e7.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=dave@linux.vnet.ibm.com \
--cc=greg@kroah.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nfont@austin.ibm.com \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).