From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Chris Ball <cjb@laptop.org>,
Anton Vorontsov <avorontsov@ru.mvista.com>,
sameo@linux.intel.com, Arnd Bergmann <arnd@arndb.de>,
patches@linaro.org, devicetree-discuss@lists.ozlabs.org,
linux-mmc@vger.kernel.org, Saeed Bishara <saeed@marvell.com>,
Xiaobo Xie <X.Xie@freescale.com>,
kernel@pengutronix.de, Mike Rapoport <mike@compulab.co.il>,
Olof Johansson <olof@lixom.net>, Shawn Guo <shawn.guo@linaro.org>,
linuxppc-dev@lists.ozlabs.org,
Albert Herranz <albert_herranz@yahoo.es>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/7] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx
Date: Wed, 25 May 2011 08:46:19 +0200 [thread overview]
Message-ID: <20110525064619.GI9774@pengutronix.de> (raw)
In-Reply-To: <20110525060637.GA30583@S2100-06.ap.freescale.net>
Hello Shawn,
> > > +#ifndef CONFIG_MMC_SDHCI_ESDHC_IMX
> > > +#define cpu_is_mx25() (0)
> > > +#define cpu_is_mx35() (0)
> > > +#define cpu_is_mx51() (0)
> > > +#define cpu_is_imx() (0)
> > > +#else
> > > +#define cpu_is_imx() (1)
> > > +#endif
> >
> > ... e.g. that looks a bit frightening.
> >
> Agree.
>
> The use of cpu_is_mx..() in the driver itself seems a churn to me
> even without this consolidation patch. Is it possible for us to
> eliminate them by using pdata, and eventually device tree? When we
> are there, I might want to revisit the consolidation again.
An alternative that allows letting the logic in the driver and still
getting rid of the cpu_is_ stuff is using platform ids. See
drivers/spi/spi_imx.c for an example. Instead of an index into an array
(as it's for the imx-spi driver) driver_data can hold flags, too, which
should be enough most of the time.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-05-25 6:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 13:22 [PATCH v2 0/7] Consolidate sdhci pltfm & OF drivers and get them self registered Shawn Guo
2011-05-05 13:22 ` [PATCH v2 1/7] mmc: sdhci: make sdhci-pltfm device drivers " Shawn Guo
2011-05-05 14:24 ` Anton Vorontsov
2011-05-05 13:22 ` [PATCH v2 2/7] mmc: sdhci: eliminate sdhci_of_host and sdhci_of_data Shawn Guo
2011-05-05 14:23 ` Anton Vorontsov
2011-05-24 19:26 ` Wolfram Sang
2011-05-05 13:22 ` [PATCH v2 3/7] mmc: sdhci: make sdhci-of device drivers self registered Shawn Guo
2011-05-05 14:23 ` Anton Vorontsov
2011-05-06 2:15 ` Shawn Guo
2011-05-24 19:32 ` Wolfram Sang
2011-05-05 13:22 ` [PATCH v2 4/7] sdhci: rename sdhci-esdhc-imx.c to sdhci-esdhc.c Shawn Guo
2011-05-05 13:22 ` [PATCH v2 5/7] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx Shawn Guo
2011-05-05 14:20 ` Anton Vorontsov
2011-05-19 9:48 ` Wolfram Sang
2011-05-24 19:40 ` Wolfram Sang
2011-05-25 6:06 ` Shawn Guo
2011-05-25 6:46 ` Uwe Kleine-König [this message]
2011-05-25 9:36 ` Shawn Guo
2011-05-05 13:22 ` [PATCH v2 6/7] mmc: sdhci: merge two sdhci-pltfm.h into one Shawn Guo
2011-05-05 14:13 ` Anton Vorontsov
2011-05-05 13:22 ` [PATCH v2 7/7] ARM: mxc: remove esdhc.h and use the public one Shawn Guo
2011-05-06 8:39 ` Uwe Kleine-König
2011-05-09 6:23 ` Shawn Guo
2011-05-19 9:40 ` [PATCH v2 0/7] Consolidate sdhci pltfm & OF drivers and get them self registered Wolfram Sang
2011-05-19 16:09 ` Shawn Guo
2011-05-19 17:05 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110525064619.GI9774@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=X.Xie@freescale.com \
--cc=albert_herranz@yahoo.es \
--cc=arnd@arndb.de \
--cc=avorontsov@ru.mvista.com \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mike@compulab.co.il \
--cc=olof@lixom.net \
--cc=patches@linaro.org \
--cc=saeed@marvell.com \
--cc=sameo@linux.intel.com \
--cc=shawn.guo@freescale.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).