From: Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>
To: Cong Wang <amwang@redhat.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Milton Miller <miltonm@bga.com>,
Anton Blanchard <anton@samba.org>
Subject: Re: [RFC PATCH v4 02/10] fadump: Reserve the memory for firmware assisted dump.
Date: Thu, 10 Nov 2011 16:13:15 +0530 [thread overview]
Message-ID: <20111110104315.GB5145@in.ibm.com> (raw)
In-Reply-To: <4EBB9FEE.9090905@redhat.com>
On 2011-11-10 17:57:02 Thu, Cong Wang wrote:
> Hi, Mahesh,
>
> Your patch seems have some style problems... checkpatch.pl complains,
>
> total: 330 errors, 1 warnings, 355 lines checked
>
> NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
> scripts/cleanfile
>
> Could use scripts/checkpatch.pl to check your patch?
I do run the checkpatch.pl before sending patches out. I am not sure how
I missed this one. Will do better job next time.
Thanks,
--
Mahesh J Salgaonkar
next prev parent reply other threads:[~2011-11-10 10:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 9:55 [RFC PATCH v4 00/10] fadump: Firmware-assisted dump support for Powerpc Mahesh J Salgaonkar
2011-11-07 9:55 ` [RFC PATCH v4 01/10] fadump: Add documentation for firmware-assisted dump Mahesh J Salgaonkar
2011-11-10 9:46 ` Cong Wang
2011-11-10 10:40 ` Mahesh J Salgaonkar
2011-11-07 9:55 ` [RFC PATCH v4 02/10] fadump: Reserve the memory for firmware assisted dump Mahesh J Salgaonkar
2011-11-10 9:57 ` Cong Wang
2011-11-10 10:43 ` Mahesh J Salgaonkar [this message]
2011-11-07 9:55 ` [RFC PATCH v4 03/10] fadump: Register " Mahesh J Salgaonkar
2011-11-07 9:55 ` [RFC PATCH v4 04/10] fadump: Initialize elfcore header and add PT_LOAD program headers Mahesh J Salgaonkar
2011-11-07 9:55 ` [RFC PATCH v4 05/10] fadump: Convert firmware-assisted cpu state dump data into elf notes Mahesh J Salgaonkar
2011-11-10 10:08 ` Cong Wang
2011-11-07 9:56 ` [RFC PATCH v4 06/10] fadump: Add PT_NOTE program header for vmcoreinfo Mahesh J Salgaonkar
2011-11-10 10:11 ` Cong Wang
2011-11-07 9:56 ` [RFC PATCH v4 07/10] fadump: Introduce cleanup routine to invalidate /proc/vmcore Mahesh J Salgaonkar
2011-11-07 9:56 ` [RFC PATCH v4 08/10] fadump: Invalidate registration and release reserved memory for general use Mahesh J Salgaonkar
2011-11-07 9:56 ` [RFC PATCH v4 09/10] fadump: Invalidate the fadump registration during machine shutdown Mahesh J Salgaonkar
2011-11-07 9:56 ` [RFC PATCH v4 10/10] fadump: Introduce config option for firmware assisted dump feature Mahesh J Salgaonkar
2011-11-10 10:10 ` Cong Wang
2011-11-10 9:24 ` [RFC PATCH v4 00/10] fadump: Firmware-assisted dump support for Powerpc Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111110104315.GB5145@in.ibm.com \
--to=mahesh@linux.vnet.ibm.com \
--cc=amwang@redhat.com \
--cc=anton@samba.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).