From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/4] poewrpc/83xx: headers cleanup
Date: Fri, 18 Nov 2011 08:12:00 +1100 [thread overview]
Message-ID: <20111118081200.ad9f082c24fed9268b4bdcee@canb.auug.org.au> (raw)
In-Reply-To: <1321541330-2330-3-git-send-email-dbaryshkov@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]
Hi Dmitry,
On Thu, 17 Nov 2011 18:48:49 +0400 Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> wrote:
>
> Drop lots of unused headers after board files merge/splitup
Please inly drop include files if nothing in them is actually used. You
need to do this by inspection, not by compilation testing. The problem
is that indirect inclusions change over time and also depending on what
CONFIG options are selected. Just a few examples below ...
> diff --git a/arch/powerpc/platforms/83xx/km83xx.c b/arch/powerpc/platforms/83xx/km83xx.c
> index 65eb792..3b29e35 100644
> --- a/arch/powerpc/platforms/83xx/km83xx.c
> +++ b/arch/powerpc/platforms/83xx/km83xx.c
> @@ -11,35 +11,9 @@
> * option) any later version.
> */
>
> -#include <linux/stddef.h>
> -#include <linux/kernel.h>
> -#include <linux/init.h>
> -#include <linux/errno.h>
> -#include <linux/reboot.h>
> -#include <linux/pci.h>
> -#include <linux/kdev_t.h>
> -#include <linux/major.h>
> -#include <linux/console.h>
> -#include <linux/delay.h>
> -#include <linux/seq_file.h>
> -#include <linux/root_dev.h>
> -#include <linux/initrd.h>
> -#include <linux/of_platform.h>
> -#include <linux/of_device.h>
Where is this file going to get its definition of "struct device_node" or
"of_find_node_by_name"?
> -#include <asm/system.h>
> -#include <linux/atomic.h>
> -#include <asm/time.h>
> -#include <asm/io.h>
> -#include <asm/machdep.h>
or "ppc_md" or "define_machine"?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-17 21:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 14:48 [PATCH 1/4] powerpc/83xx: consolidate of_platform_bus_probe calls Dmitry Eremin-Solenikov
2011-11-17 14:48 ` [PATCH 2/4] powerpc/83xx: merge PCI bridge additions Dmitry Eremin-Solenikov
2011-11-24 6:40 ` Kumar Gala
2011-11-17 14:48 ` [PATCH 3/4] poewrpc/83xx: headers cleanup Dmitry Eremin-Solenikov
2011-11-17 21:12 ` Stephen Rothwell [this message]
2011-11-17 14:48 ` [PATCH 4/4] powerpc/83xx: make mpc830x_rdb use mpc83xx_setup_pci Dmitry Eremin-Solenikov
2011-11-24 6:40 ` Kumar Gala
2011-11-24 6:40 ` [PATCH 1/4] powerpc/83xx: consolidate of_platform_bus_probe calls Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118081200.ad9f082c24fed9268b4bdcee@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=dbaryshkov@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).