From: Tony Breeds <tony@bakeyournoodle.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Jiri Kosina <jkosina@suse.cz>,
LinuxPPC-dev <linuxppc-dev@lists.ozlabs.org>,
Linux Kernel ML <linux-kernel@vger.kernel.org>
Subject: linux-next bad Kconfig for drivers/hid
Date: Fri, 9 Dec 2011 12:27:46 +1100 [thread overview]
Message-ID: <20111209012746.GC20353@thor.bakeyournoodle.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]
Commit 4f5ca836bef3 (HID: hid-input: add support for HID devices
reporting Battery Strength) went into linux-next on Dec 1st since then a
ppc6xx_defconfig has been failing with:
---
drivers/built-in.o: In function `hidinput_cleanup_battery':
/scratch/tony/working/drivers/hid/hid-input.c:351: undefined reference to `power_supply_unregister'
drivers/built-in.o: In function `hidinput_setup_battery':
/scratch/tony/working/drivers/hid/hid-input.c:338: undefined reference to `power_supply_register'
make[1]: *** [.tmp_vmlinux1] Error 1
---
http://kisskb.ellerman.id.au/kisskb/buildresult/5012563/
vs
http://kisskb.ellerman.id.au/kisskb/buildresult/5017366/
The defconfig in question doens't mention either option
(CONFIG_POWER_SUPPLY or CONFIG_HID_BATTERY_STRENGTH) and kbuild is
genertaing
CONFIG_HID_BATTERY_STRENGTH=y
CONFIG_POWER_SUPPLY=m
which clearly isn't going to work.
The following change to HID_BATTERY_STRENGTH Kconfig "works" but seems a
little gross.
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 5ed64f6..d2a94e6 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -33,7 +33,7 @@ config HID
config HID_BATTERY_STRENGTH
bool
- depends on POWER_SUPPLY
+ depends on POWER_SUPPLY=y
default y
config HIDRAW
Any chance we can get a fix into linux-next?
Yours Tony
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2011-12-09 1:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 1:27 Tony Breeds [this message]
2011-12-09 5:33 ` linux-next bad Kconfig for drivers/hid Jeremy Fitzhardinge
2011-12-09 19:00 ` Randy Dunlap
2011-12-11 23:21 ` Jiri Kosina
2011-12-12 0:31 ` Tony Breeds
2011-12-15 10:08 ` Jiri Kosina
2011-12-15 11:44 ` Tony Breeds
2011-12-15 17:43 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111209012746.GC20353@thor.bakeyournoodle.com \
--to=tony@bakeyournoodle.com \
--cc=jeremy@goop.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).