From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: tglx@linutronix.de, peterz@infradead.org, tj@kernel.org,
oleg@redhat.com, paulmck@linux.vnet.ibm.com,
rusty@rustcorp.com.au, mingo@kernel.org,
akpm@linux-foundation.org, namhyung@kernel.org
Cc: linux-arch@vger.kernel.org, linux@arm.linux.org.uk,
nikunj@linux.vnet.ibm.com, linux-pm@vger.kernel.org,
fweisbec@gmail.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, rostedt@goodmis.org,
xiaoguangrong@linux.vnet.ibm.com, rjw@sisk.pl, sbw@mit.edu,
wangyun@linux.vnet.ibm.com, srivatsa.bhat@linux.vnet.ibm.com,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 29/45] x86/xen: Use get/put_online_cpus_atomic() to prevent CPU offline
Date: Tue, 22 Jan 2013 13:10:51 +0530 [thread overview]
Message-ID: <20130122074046.13822.61950.stgit@srivatsabhat.in.ibm.com> (raw)
In-Reply-To: <20130122073210.13822.50434.stgit@srivatsabhat.in.ibm.com>
Once stop_machine() is gone from the CPU offline path, we won't be able to
depend on preempt_disable() or local_irq_disable() to prevent CPUs from
going offline from under us.
Use the get/put_online_cpus_atomic() APIs to prevent CPUs from going offline,
while invoking from atomic context.
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: xen-devel@lists.xensource.com
Cc: virtualization@lists.linux-foundation.org
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
---
arch/x86/xen/mmu.c | 11 +++++++++--
arch/x86/xen/smp.c | 9 +++++++++
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index 01de35c..6a95a15 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -39,6 +39,7 @@
* Jeremy Fitzhardinge <jeremy@xensource.com>, XenSource Inc, 2007
*/
#include <linux/sched.h>
+#include <linux/cpu.h>
#include <linux/highmem.h>
#include <linux/debugfs.h>
#include <linux/bug.h>
@@ -1163,9 +1164,13 @@ static void xen_drop_mm_ref(struct mm_struct *mm)
*/
static void xen_exit_mmap(struct mm_struct *mm)
{
- get_cpu(); /* make sure we don't move around */
+ /*
+ * Make sure we don't move around, and prevent CPUs from going
+ * offline.
+ */
+ get_online_cpus_atomic();
xen_drop_mm_ref(mm);
- put_cpu();
+ put_online_cpus_atomic();
spin_lock(&mm->page_table_lock);
@@ -1371,6 +1376,7 @@ static void xen_flush_tlb_others(const struct cpumask *cpus,
args->op.arg2.vcpumask = to_cpumask(args->mask);
/* Remove us, and any offline CPUS. */
+ get_online_cpus_atomic();
cpumask_and(to_cpumask(args->mask), cpus, cpu_online_mask);
cpumask_clear_cpu(smp_processor_id(), to_cpumask(args->mask));
@@ -1383,6 +1389,7 @@ static void xen_flush_tlb_others(const struct cpumask *cpus,
MULTI_mmuext_op(mcs.mc, &args->op, 1, NULL, DOMID_SELF);
xen_mc_issue(PARAVIRT_LAZY_MMU);
+ put_online_cpus_atomic();
}
static unsigned long xen_read_cr3(void)
diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
index 4f7d259..7d753ae 100644
--- a/arch/x86/xen/smp.c
+++ b/arch/x86/xen/smp.c
@@ -16,6 +16,7 @@
#include <linux/err.h>
#include <linux/slab.h>
#include <linux/smp.h>
+#include <linux/cpu.h>
#include <linux/irq_work.h>
#include <asm/paravirt.h>
@@ -487,8 +488,10 @@ static void __xen_send_IPI_mask(const struct cpumask *mask,
{
unsigned cpu;
+ get_online_cpus_atomic();
for_each_cpu_and(cpu, mask, cpu_online_mask)
xen_send_IPI_one(cpu, vector);
+ put_online_cpus_atomic();
}
static void xen_smp_send_call_function_ipi(const struct cpumask *mask)
@@ -551,8 +554,10 @@ void xen_send_IPI_all(int vector)
{
int xen_vector = xen_map_vector(vector);
+ get_online_cpus_atomic();
if (xen_vector >= 0)
__xen_send_IPI_mask(cpu_online_mask, xen_vector);
+ put_online_cpus_atomic();
}
void xen_send_IPI_self(int vector)
@@ -572,20 +577,24 @@ void xen_send_IPI_mask_allbutself(const struct cpumask *mask,
if (!(num_online_cpus() > 1))
return;
+ get_online_cpus_atomic();
for_each_cpu_and(cpu, mask, cpu_online_mask) {
if (this_cpu == cpu)
continue;
xen_smp_send_call_function_single_ipi(cpu);
}
+ put_online_cpus_atomic();
}
void xen_send_IPI_allbutself(int vector)
{
int xen_vector = xen_map_vector(vector);
+ get_online_cpus_atomic();
if (xen_vector >= 0)
xen_send_IPI_mask_allbutself(cpu_online_mask, xen_vector);
+ put_online_cpus_atomic();
}
static irqreturn_t xen_call_function_interrupt(int irq, void *dev_id)
next prev parent reply other threads:[~2013-01-22 7:42 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 7:33 [PATCH v5 00/45] CPU hotplug: stop_machine()-free CPU hotplug Srivatsa S. Bhat
2013-01-22 7:33 ` [PATCH v5 01/45] percpu_rwlock: Introduce the global reader-writer lock backend Srivatsa S. Bhat
2013-01-22 18:45 ` Stephen Hemminger
2013-01-22 19:41 ` Srivatsa S. Bhat
2013-01-22 19:32 ` Steven Rostedt
2013-01-22 19:58 ` Srivatsa S. Bhat
2013-01-22 20:54 ` Steven Rostedt
2013-01-24 4:14 ` Michel Lespinasse
2013-01-24 15:58 ` Oleg Nesterov
2013-01-22 7:33 ` [PATCH v5 02/45] percpu_rwlock: Introduce per-CPU variables for the reader and the writer Srivatsa S. Bhat
2013-01-22 7:33 ` [PATCH v5 03/45] percpu_rwlock: Provide a way to define and init percpu-rwlocks at compile time Srivatsa S. Bhat
2013-01-22 7:33 ` [PATCH v5 04/45] percpu_rwlock: Implement the core design of Per-CPU Reader-Writer Locks Srivatsa S. Bhat
2013-01-23 18:55 ` Tejun Heo
2013-01-23 19:33 ` Srivatsa S. Bhat
2013-01-23 19:57 ` Tejun Heo
2013-01-24 4:30 ` Srivatsa S. Bhat
2013-01-29 11:12 ` Namhyung Kim
2013-02-08 22:47 ` Paul E. McKenney
2013-02-10 18:38 ` Srivatsa S. Bhat
2013-02-08 23:10 ` Paul E. McKenney
2013-02-10 18:06 ` Oleg Nesterov
2013-02-10 19:24 ` Srivatsa S. Bhat
2013-02-10 19:50 ` Oleg Nesterov
2013-02-10 20:09 ` Srivatsa S. Bhat
2013-02-10 22:13 ` Paul E. McKenney
2013-02-10 19:54 ` Paul E. McKenney
2013-02-12 16:15 ` Paul E. McKenney
2013-02-10 19:10 ` Srivatsa S. Bhat
2013-02-10 19:47 ` Paul E. McKenney
2013-02-10 19:57 ` Srivatsa S. Bhat
2013-02-10 20:13 ` Oleg Nesterov
2013-02-10 20:20 ` Srivatsa S. Bhat
2013-01-22 7:34 ` [PATCH v5 05/45] percpu_rwlock: Make percpu-rwlocks IRQ-safe, optimally Srivatsa S. Bhat
2013-02-08 23:44 ` Paul E. McKenney
2013-02-10 19:27 ` Srivatsa S. Bhat
2013-02-10 18:42 ` Oleg Nesterov
2013-02-10 19:30 ` Srivatsa S. Bhat
2013-01-22 7:34 ` [PATCH v5 06/45] percpu_rwlock: Allow writers to be readers, and add lockdep annotations Srivatsa S. Bhat
2013-02-08 23:47 ` Paul E. McKenney
2013-02-10 19:32 ` Srivatsa S. Bhat
2013-01-22 7:34 ` [PATCH v5 07/45] CPU hotplug: Provide APIs to prevent CPU offline from atomic context Srivatsa S. Bhat
2013-01-29 10:21 ` Namhyung Kim
2013-02-10 19:34 ` Srivatsa S. Bhat
2013-02-08 23:50 ` Paul E. McKenney
2013-01-22 7:35 ` [PATCH v5 08/45] CPU hotplug: Convert preprocessor macros to static inline functions Srivatsa S. Bhat
2013-02-08 23:51 ` Paul E. McKenney
2013-01-22 7:35 ` [PATCH v5 09/45] smp, cpu hotplug: Fix smp_call_function_*() to prevent CPU offline properly Srivatsa S. Bhat
2013-02-09 0:07 ` Paul E. McKenney
2013-02-10 19:41 ` Srivatsa S. Bhat
2013-02-10 19:56 ` Paul E. McKenney
2013-02-10 19:59 ` Srivatsa S. Bhat
2013-01-22 7:35 ` [PATCH v5 10/45] smp, cpu hotplug: Fix on_each_cpu_*() " Srivatsa S. Bhat
2013-01-22 7:35 ` [PATCH v5 11/45] sched/timer: Use get/put_online_cpus_atomic() to prevent CPU offline Srivatsa S. Bhat
2013-01-22 7:35 ` [PATCH v5 12/45] sched/migration: Use raw_spin_lock/unlock since interrupts are already disabled Srivatsa S. Bhat
2013-01-22 7:36 ` [PATCH v5 13/45] sched/rt: Use get/put_online_cpus_atomic() to prevent CPU offline Srivatsa S. Bhat
2013-01-22 7:36 ` [PATCH v5 14/45] rcu, CPU hotplug: Fix comment referring to stop_machine() Srivatsa S. Bhat
2013-02-09 0:14 ` Paul E. McKenney
2013-02-10 19:43 ` Srivatsa S. Bhat
2013-01-22 7:36 ` [PATCH v5 15/45] tick: Use get/put_online_cpus_atomic() to prevent CPU offline Srivatsa S. Bhat
2013-01-22 7:37 ` [PATCH v5 16/45] time/clocksource: " Srivatsa S. Bhat
2013-01-22 7:37 ` [PATCH v5 17/45] softirq: " Srivatsa S. Bhat
2013-01-22 7:38 ` [PATCH v5 18/45] irq: " Srivatsa S. Bhat
2013-01-22 7:38 ` [PATCH v5 19/45] net: " Srivatsa S. Bhat
2013-01-22 7:38 ` [PATCH v5 20/45] block: " Srivatsa S. Bhat
2013-01-22 7:38 ` [PATCH v5 21/45] crypto: pcrypt - Protect access to cpu_online_mask with get/put_online_cpus() Srivatsa S. Bhat
2013-01-22 7:39 ` [PATCH v5 22/45] infiniband: ehca: Use get/put_online_cpus_atomic() to prevent CPU offline Srivatsa S. Bhat
2013-01-22 7:39 ` [PATCH v5 23/45] [SCSI] fcoe: " Srivatsa S. Bhat
2013-01-22 7:39 ` [PATCH v5 24/45] staging: octeon: " Srivatsa S. Bhat
2013-01-22 7:39 ` [PATCH v5 25/45] x86: " Srivatsa S. Bhat
2013-01-22 7:39 ` [PATCH v5 26/45] perf/x86: " Srivatsa S. Bhat
2013-01-22 7:40 ` [PATCH v5 27/45] KVM: Use get/put_online_cpus_atomic() to prevent CPU offline from atomic context Srivatsa S. Bhat
2013-01-22 7:40 ` [PATCH v5 28/45] kvm/vmx: Use get/put_online_cpus_atomic() to prevent CPU offline Srivatsa S. Bhat
2013-01-22 7:40 ` Srivatsa S. Bhat [this message]
2013-02-19 18:10 ` [PATCH v5 29/45] x86/xen: " Konrad Rzeszutek Wilk
2013-02-19 18:29 ` Srivatsa S. Bhat
2013-01-22 7:41 ` [PATCH v5 30/45] alpha/smp: " Srivatsa S. Bhat
2013-01-22 7:41 ` [PATCH v5 31/45] blackfin/smp: " Srivatsa S. Bhat
2013-01-28 9:09 ` Bob Liu
2013-01-28 19:06 ` Tejun Heo
2013-01-29 1:14 ` Srivatsa S. Bhat
2013-01-22 7:41 ` [PATCH v5 32/45] cris/smp: " Srivatsa S. Bhat
2013-01-22 7:42 ` [PATCH v5 33/45] hexagon/smp: " Srivatsa S. Bhat
2013-01-22 7:42 ` [PATCH v5 34/45] ia64: " Srivatsa S. Bhat
2013-01-22 7:42 ` [PATCH v5 35/45] m32r: " Srivatsa S. Bhat
2013-01-22 7:42 ` [PATCH v5 36/45] MIPS: " Srivatsa S. Bhat
2013-01-22 7:43 ` [PATCH v5 37/45] mn10300: " Srivatsa S. Bhat
2013-01-22 7:43 ` [PATCH v5 38/45] parisc: " Srivatsa S. Bhat
2013-01-22 7:43 ` [PATCH v5 39/45] powerpc: " Srivatsa S. Bhat
2013-01-22 7:44 ` [PATCH v5 40/45] sh: " Srivatsa S. Bhat
2013-01-22 7:44 ` [PATCH v5 41/45] sparc: " Srivatsa S. Bhat
2013-01-22 7:44 ` [PATCH v5 42/45] tile: " Srivatsa S. Bhat
2013-01-22 7:44 ` [PATCH v5 43/45] cpu: No more __stop_machine() in _cpu_down() Srivatsa S. Bhat
2013-01-22 7:45 ` [PATCH v5 44/45] CPU hotplug, stop_machine: Decouple CPU hotplug from stop_machine() in Kconfig Srivatsa S. Bhat
2013-02-09 0:15 ` Paul E. McKenney
2013-02-10 19:45 ` Srivatsa S. Bhat
2013-01-22 7:45 ` [PATCH v5 45/45] Documentation/cpu-hotplug: Remove references to stop_machine() Srivatsa S. Bhat
2013-02-09 0:16 ` Paul E. McKenney
2013-02-04 13:47 ` [PATCH v5 00/45] CPU hotplug: stop_machine()-free CPU hotplug Srivatsa S. Bhat
2013-02-07 4:14 ` Rusty Russell
2013-02-07 6:11 ` Srivatsa S. Bhat
2013-02-08 15:41 ` Russell King - ARM Linux
2013-02-08 16:44 ` Srivatsa S. Bhat
2013-02-08 18:09 ` Srivatsa S. Bhat
2013-02-11 11:58 ` Vincent Guittot
2013-02-11 12:23 ` Srivatsa S. Bhat
2013-02-11 19:08 ` Paul E. McKenney
2013-02-12 3:58 ` Srivatsa S. Bhat
2013-02-15 13:28 ` Vincent Guittot
2013-02-15 19:40 ` Srivatsa S. Bhat
2013-02-18 10:24 ` Vincent Guittot
2013-02-18 10:34 ` Srivatsa S. Bhat
2013-02-18 10:51 ` Srivatsa S. Bhat
2013-02-18 10:58 ` Vincent Guittot
2013-02-18 15:30 ` Steven Rostedt
2013-02-18 16:50 ` Vincent Guittot
2013-02-18 19:53 ` Steven Rostedt
2013-02-18 19:53 ` Steven Rostedt
2013-02-19 10:33 ` Vincent Guittot
2013-02-18 10:54 ` Thomas Gleixner
2013-02-18 10:57 ` Srivatsa S. Bhat
2013-02-11 12:41 ` [PATCH v5 01/45] percpu_rwlock: Introduce the global reader-writer lock backend David Howells
2013-02-11 12:56 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122074046.13822.61950.stgit@srivatsabhat.in.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikunj@linux.vnet.ibm.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=sbw@mit.edu \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=wangyun@linux.vnet.ibm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).