From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: ppcdev <linuxppc-dev@lists.ozlabs.org>,
lkml <linux-kernel@vger.kernel.org>,
oleg@redhat.com
Subject: Re: [PATCH v2 2/4] uprobes: refuse uprobe on trap variants
Date: Tue, 26 Mar 2013 17:36:26 +0530 [thread overview]
Message-ID: <20130326120626.GB20399@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130322151758.GC20010@in.ibm.com>
* Ananth N Mavinakayanahalli <ananth@in.ibm.com> [2013-03-22 20:47:58]:
> From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>
> Refuse to place a uprobe if a trap variant already exists in the
> file copy at the address.
>
> Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
> kernel/events/uprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-3.9-rc3/kernel/events/uprobes.c
> ===================================================================
> --- linux-3.9-rc3.orig/kernel/events/uprobes.c
> +++ linux-3.9-rc3/kernel/events/uprobes.c
> @@ -573,7 +573,7 @@ static int prepare_uprobe(struct uprobe
> goto out;
>
> ret = -ENOTSUPP;
> - if (is_swbp_insn((uprobe_opcode_t *)uprobe->arch.insn))
> + if (is_trap_insn((uprobe_opcode_t *)uprobe->arch.insn))
> goto out;
>
> ret = arch_uprobe_analyze_insn(&uprobe->arch, mm, vaddr);
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2013-03-26 12:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 15:16 [PATCH v2 1/4] uprobes: add trap variant helper Ananth N Mavinakayanahalli
2013-03-22 15:17 ` [PATCH v2 2/4] uprobes: refuse uprobe on trap variants Ananth N Mavinakayanahalli
2013-03-26 12:06 ` Srikar Dronamraju [this message]
2013-03-22 15:18 ` [PATCH v2 3/4] uprobes/powerpc: teach uprobes to ignore gdb breakpoints Ananth N Mavinakayanahalli
2013-03-26 12:06 ` Srikar Dronamraju
2013-03-22 15:19 ` [PATCH v2 4/4] uprobes/powerpc: remove additional trap instruction check Ananth N Mavinakayanahalli
2013-03-26 12:07 ` Srikar Dronamraju
2013-03-23 18:08 ` [PATCH v2 1/4] uprobes: add trap variant helper Oleg Nesterov
2013-03-26 12:06 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326120626.GB20399@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).