linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: tytso@mit.edu, herbert@gondor.apana.org.au, gleb@redhat.com,
	agraf@suse.de, kvm-ppc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	Paul Mackerras <paulus@samba.org>,
	kvm@vger.kernel.org, mpm@selenic.com, pbonzini@redhat.com
Subject: Re: [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems
Date: Tue, 1 Oct 2013 18:36:15 +1000	[thread overview]
Message-ID: <20131001083615.GC27484@concordia> (raw)
In-Reply-To: <52459311.4010104@linux.vnet.ibm.com>

On Fri, Sep 27, 2013 at 07:45:45PM +0530, Anshuman Khandual wrote:
> On 09/26/2013 12:01 PM, Michael Ellerman wrote:
> > +int powernv_hwrng_present(void)
> > +{
> > +	return __raw_get_cpu_var(powernv_rng) != NULL;
> > +}
> > +
> >  static unsigned long rng_whiten(struct powernv_rng *rng, unsigned long val)
> >  {
> >  	unsigned long parity;
> > @@ -42,6 +48,17 @@ static unsigned long rng_whiten(struct powernv_rng *rng, unsigned long val)
> >  	return val;
> >  }
> > 
> > +int powernv_get_random_real_mode(unsigned long *v)
> > +{
> > +	struct powernv_rng *rng;
> > +
> > +	rng = __raw_get_cpu_var(powernv_rng);
> > +
> > +	*v = rng_whiten(rng, in_rm64(rng->regs_real));
> > +
> 
> Will it be in_be64() instead of in_rm64() ? Its failing the build here. Except this
> all individual patches build correctly.

No it's definitely not in_be64() - that will checkstop your machine :)

I added in_rm64() in a previous patch, "Add real mode cache inhibited
IO accessors" - I just didn't want to spam the KVM guys with those
patches as well.

Thanks for the review & testing.

cheers

  reply	other threads:[~2013-10-01  8:36 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26  6:31 [PATCH 1/3] powerpc: Implement arch_get_random_long/int() for powernv Michael Ellerman
2013-09-26  6:31 ` [PATCH 2/3] hwrng: Add a driver for the hwrng found in power7+ systems Michael Ellerman
2013-09-26  8:01   ` Benjamin Herrenschmidt
2013-10-01  8:25     ` Michael Ellerman
2013-09-26  6:31 ` [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems Michael Ellerman
2013-09-26  9:06   ` Paolo Bonzini
2013-10-01  8:34     ` Michael Ellerman
2013-10-01  8:39       ` Gleb Natapov
2013-10-01  9:23         ` Paul Mackerras
2013-10-01  9:57           ` Gleb Natapov
2013-10-01 10:00           ` Alexander Graf
2013-10-01  9:38         ` Benjamin Herrenschmidt
2013-10-01 11:19           ` Paolo Bonzini
2013-10-01 21:44             ` Benjamin Herrenschmidt
2013-10-02  8:38               ` Paolo Bonzini
2013-10-02  5:09             ` Paul Mackerras
2013-10-02  8:46               ` Paolo Bonzini
2013-10-02  9:06                 ` Benjamin Herrenschmidt
2013-10-02  9:11                   ` Alexander Graf
2013-10-02  9:50                     ` Alexander Graf
2013-10-02 10:02                       ` Gleb Natapov
2013-10-02 13:57                         ` Michael Ellerman
2013-10-02 14:08                           ` Alexander Graf
2013-10-02 14:33                             ` Paolo Bonzini
2013-10-02 14:36                               ` Alexander Graf
2013-10-02 14:38                                 ` Paolo Bonzini
2013-10-02 22:45                                 ` Paul Mackerras
2013-10-03  5:48                                   ` Gleb Natapov
2013-10-03 10:06                                     ` Paul Mackerras
2013-10-03 12:08                                       ` Gleb Natapov
2013-10-02 14:37                               ` Gleb Natapov
2013-10-02 22:21                                 ` Benjamin Herrenschmidt
2013-10-03  6:08                                   ` Gleb Natapov
2013-10-02 22:13                             ` Benjamin Herrenschmidt
2013-10-02 14:10                           ` Gleb Natapov
2013-10-02 22:15                             ` Benjamin Herrenschmidt
2013-10-02 22:02                         ` Benjamin Herrenschmidt
2013-10-03  5:43                           ` Gleb Natapov
2013-10-03  7:22                             ` Benjamin Herrenschmidt
2013-10-02 22:07                         ` Benjamin Herrenschmidt
2013-10-03  6:28                           ` Gleb Natapov
2013-10-02 21:58                     ` Benjamin Herrenschmidt
2013-10-01  9:58       ` Paolo Bonzini
2013-09-27 14:15   ` Anshuman Khandual
2013-10-01  8:36     ` Michael Ellerman [this message]
2013-09-26  7:58 ` [PATCH 1/3] powerpc: Implement arch_get_random_long/int() for powernv Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131001083615.GC27484@concordia \
    --to=michael@ellerman.id.au \
    --cc=agraf@suse.de \
    --cc=gleb@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mpm@selenic.com \
    --cc=paulus@samba.org \
    --cc=pbonzini@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).