linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Gerhard Sittig <gsi@denx.de>
To: Alexander Popov <a13xp0p0v88@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Arnd Bergmann <arnd@arndb.de>, Vinod Koul <vinod.koul@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Anatolij Gustschin <agust@denx.de>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH RFC v7 1/6] dma: mpc512x: reorder mpc8308 specific instructions
Date: Wed, 12 Feb 2014 20:21:50 +0100	[thread overview]
Message-ID: <20140212192150.GH4524@book.gsilab.sittig.org> (raw)
In-Reply-To: <1392211508-23615-2-git-send-email-a13xp0p0v88@gmail.com>

[ removed DT from Cc: ]

On Wed, Feb 12, 2014 at 17:25 +0400, Alexander Popov wrote:
> 
> Concentrate the specific code for MPC8308 in the 'if' branch
> and handle MPC512x in the 'else' branch.
> This modification only reorders instructions but doesn't change behaviour.

As this one is an obvious improvement and straight forward, it
can be taken regardless of the remainder of the series.  (I guess
this formerly stated judgement is what made Alexander derive
Acked-By tags from.)


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de

  reply	other threads:[~2014-02-12 19:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12 13:25 [PATCH RFC v7 0/6] MPC512x DMA slave s/g support, OF DMA lookup Alexander Popov
2014-02-12 13:25 ` [PATCH RFC v7 1/6] dma: mpc512x: reorder mpc8308 specific instructions Alexander Popov
2014-02-12 19:21   ` Gerhard Sittig [this message]
2014-02-12 13:25 ` [PATCH RFC v7 2/6] dma: mpc512x: add support for peripheral transfers Alexander Popov
2014-02-13  0:07   ` Gerhard Sittig
2014-02-19 14:45     ` Alexander Popov
2014-02-12 13:25 ` [PATCH RFC v7 3/6] dma: of: Add common xlate function for matching by channel id Alexander Popov
2014-02-12 13:25 ` [PATCH RFC v7 4/6] dma: mpc512x: add device tree binding document Alexander Popov
2014-02-13  0:21   ` Gerhard Sittig
2014-02-12 13:25 ` [PATCH RFC v7 5/6] dma: mpc512x: register for device tree channel lookup Alexander Popov
2014-02-12 13:25 ` [PATCH RFC v7 6/6] HACK mmc: mxcmmc: enable clocks for the MPC512x Alexander Popov
2014-02-13  0:24   ` Gerhard Sittig
2014-02-13  0:32 ` [PATCH RFC v7 0/6] MPC512x DMA slave s/g support, OF DMA lookup Gerhard Sittig
2014-02-19 13:17   ` Alexander Popov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140212192150.GH4524@book.gsilab.sittig.org \
    --to=gsi@denx.de \
    --cc=a13xp0p0v88@gmail.com \
    --cc=agust@denx.de \
    --cc=arnd@arndb.de \
    --cc=dan.j.williams@intel.com \
    --cc=lars@metafoo.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).