From: Gautham R Shenoy <ego@linux.vnet.ibm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>,
Linux PM list <linux-pm@vger.kernel.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v3 4/5] powernv:cpufreq: Export nominal frequency via sysfs.
Date: Fri, 21 Mar 2014 15:25:34 +0530 [thread overview]
Message-ID: <20140321095534.GF27293@in.ibm.com> (raw)
In-Reply-To: <CAOh2x=kLwDGFtHR5sBKhE-9L=3=npV4_i+B+BVm+yBocmmMvzQ@mail.gmail.com>
On Fri, Mar 21, 2014 at 02:17:28PM +0530, Viresh Kumar wrote:
> > +static ssize_t show_cpuinfo_nominal_freq(struct cpufreq_policy *policy,
> > + char *buf)
> > +{
> > + int nominal_freq;
> > + nominal_freq = pstate_id_to_freq(powernv_pstate_info.pstate_nominal_id);
> > + return sprintf(buf, "%u\n", nominal_freq);
>
> return sprintf(buf, "%u\n",
> pstate_id_to_freq(powernv_pstate_info.pstate_nominal_id));
Sure. Will fix this.
>
> ??
>
> > +}
> > +
> > +
>
> remove extra blank line.
>
> > +struct freq_attr cpufreq_freq_attr_cpuinfo_nominal_freq = {
> > + .attr = { .name = "cpuinfo_nominal_freq",
> > + .mode = 0444,
> > + },
>
> Align {}
Probably the use of ATTR_RO(cpuinfo_nominal_freq) and renaming
show_cpuinfo_nominal_freq to cpuinfo_nominal_freq_show() would be even
better. What do you think ?
>
> > + .show = show_cpuinfo_nominal_freq,
> > +};
> > +
> > +
> > static struct freq_attr *powernv_cpu_freq_attr[] = {
> > &cpufreq_freq_attr_scaling_available_freqs,
> > + &cpufreq_freq_attr_cpuinfo_nominal_freq,
> > NULL,
> > };
This needs to be rewritten to include the entries of cpufreq_generic_attr.
>
Thanks for the review.
--
Regards
gautham.
next prev parent reply other threads:[~2014-03-21 9:55 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 12:10 [PATCH v3 0/5] powernv: Enable Dynamic Frequency Gautham R. Shenoy
2014-03-20 12:10 ` [PATCH v3 1/5] powernv: cpufreq driver for powernv platform Gautham R. Shenoy
2014-03-21 8:41 ` Viresh Kumar
2014-03-21 10:43 ` Gautham R Shenoy
2014-03-21 10:54 ` Viresh Kumar
2014-03-21 11:40 ` Srivatsa S. Bhat
2014-03-21 13:23 ` Gautham R Shenoy
2014-03-21 13:34 ` Viresh Kumar
2014-03-21 14:54 ` Gautham R Shenoy
2014-03-22 3:43 ` Viresh Kumar
2014-03-21 14:48 ` Vaidyanathan Srinivasan
2014-03-22 3:43 ` Viresh Kumar
2014-03-21 11:45 ` Srivatsa S. Bhat
2014-03-21 11:47 ` Viresh Kumar
2014-03-20 12:10 ` [PATCH v3 2/5] powernv, cpufreq:Add per-core locking to serialize frequency transitions Gautham R. Shenoy
2014-03-21 6:24 ` Gautham R Shenoy
2014-03-21 8:42 ` Viresh Kumar
2014-03-21 9:56 ` Srivatsa S. Bhat
2014-03-20 12:10 ` [PATCH v3 3/5] powernv:cpufreq: Create pstate_id_to_freq() helper Gautham R. Shenoy
2014-03-21 6:24 ` Gautham R Shenoy
2014-03-20 12:10 ` [PATCH v3 4/5] powernv:cpufreq: Export nominal frequency via sysfs Gautham R. Shenoy
2014-03-21 8:47 ` Viresh Kumar
2014-03-21 9:55 ` Gautham R Shenoy [this message]
2014-03-21 9:57 ` Viresh Kumar
2014-03-20 12:11 ` [PATCH v3 5/5] powernv:cpufreq: Implement the driver->get() method Gautham R. Shenoy
2014-03-21 6:25 ` Gautham R Shenoy
2014-03-21 9:31 ` Viresh Kumar
2014-03-21 11:04 ` Gautham R Shenoy
2014-03-21 11:45 ` Viresh Kumar
2014-03-21 12:01 ` David Laight
2014-03-21 12:31 ` Gautham R Shenoy
2014-03-21 12:34 ` Viresh Kumar
2014-03-21 15:01 ` David Laight
2014-03-21 13:04 ` Gautham R Shenoy
2014-03-21 13:12 ` Viresh Kumar
2014-03-21 14:25 ` Gautham R Shenoy
2014-03-21 22:56 ` Benjamin Herrenschmidt
2014-03-22 7:53 ` Gautham R Shenoy
2014-03-21 7:46 ` [PATCH v3 0/5] powernv: Enable Dynamic Frequency Viresh Kumar
2014-03-21 8:19 ` Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321095534.GF27293@in.ibm.com \
--to=ego@linux.vnet.ibm.com \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).