From: Tony Breeds <tony@bakeyournoodle.com>
To: Anton Blanchard <anton@samba.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
linuxppc-dev@lists.ozlabs.org, Christoph Lameter <cl@gentwo.org>
Subject: Re: Kernel build issues after yesterdays merge by Linus
Date: Fri, 13 Jun 2014 15:15:59 +1000 [thread overview]
Message-ID: <20140613051559.GC19628@thor.bakeyournoodle.com> (raw)
In-Reply-To: <20140612220912.3447677f@kryten>
[-- Attachment #1: Type: text/plain, Size: 1704 bytes --]
On Thu, Jun 12, 2014 at 10:09:12PM +1000, Anton Blanchard wrote:
> The TOC symbol export is special and I think we might need to get our
> script to ignore it.
Try this (untested) patch. If it's good I'll send it to Ben.
diff --git a/arch/powerpc/relocs_check.pl b/arch/powerpc/relocs_check.pl
index 3f46e8b..34e3f25 100755
--- a/arch/powerpc/relocs_check.pl
+++ b/arch/powerpc/relocs_check.pl
@@ -45,6 +45,9 @@ while (<FD>) {
/\bR_PPC_ADDR16_HA\b/ or /\bR_PPC_RELATIVE\b/ or
/\bR_PPC_NONE\b/);
+ # The TOC is "special" so let's ignore it.
+ next if (/__crc_TOC\./);
+
# If we see this type of relocation it's an idication that
# we /may/ be using an old version of binutils.
if (/R_PPC64_UADDR64/) {
<snip>
> Shows how much we use make install :) Below is a quick hack to get you going
> but we should look at either fixing the Ubuntu installkernel to handle
> extra optional args, or stop passing them from the ppc64 kernel
> install.sh script.
It seems like passign the zImage files is probably wrong. How about:
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index ccc25ed..146d898 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -390,7 +390,7 @@ $(obj)/zImage.initrd: $(addprefix $(obj)/, $(initrd-y))
@rm -f $@; ln $< $@
install: $(CONFIGURE) $(addprefix $(obj)/, $(image-y))
- sh -x $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)" $^
+ sh -x $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)"
# anything not in $(targets)
clean-files += $(image-) $(initrd-) cuImage.* dtbImage.* treeImage.* \
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-13 5:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 15:44 Kernel build issues after yesterdays merge by Linus Christoph Lameter
2014-06-11 20:26 ` Benjamin Herrenschmidt
2014-06-12 12:09 ` Anton Blanchard
2014-06-12 12:36 ` David Laight
2014-06-13 1:56 ` Christoph Lameter
2014-06-13 5:15 ` Tony Breeds [this message]
2014-07-08 1:06 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613051559.GC19628@thor.bakeyournoodle.com \
--to=tony@bakeyournoodle.com \
--cc=anton@samba.org \
--cc=cl@gentwo.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).