From: Segher Boessenkool <segher@kernel.crashing.org>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: kvm@vger.kernel.org, agraf@suse.de, kvm-ppc@vger.kernel.org,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint
Date: Sun, 3 Aug 2014 10:51:08 -0500 [thread overview]
Message-ID: <20140803155108.GA19710@gate.crashing.org> (raw)
In-Reply-To: <1406868643-26291-1-git-send-email-maddy@linux.vnet.ibm.com>
> +/*
> + * KVMPPC_INST_BOOK3S_DEBUG is debug Instruction for supporting Software Breakpoint.
> + * Based on PowerISA v2.07, Instruction with opcode 0s will be treated as illegal
> + * instruction.
> + */
"primary opcode 0" instead?
> +#define OP_ZERO 0x0
Using 0x0 where you mean 0, making a #define for 0 in the first place...
This all looks rather silly doesn't it.
> + case OP_ZERO:
> + if((inst & 0x00FFFF00) == KVMPPC_INST_BOOK3S_DEBUG) {
You either shouldn't mask at all here, or the mask is wrong (the primary
op is the top six bits, not the top eight).
Segher
next prev parent reply other threads:[~2014-08-03 15:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 4:50 [PATCH v3] powerpc/kvm: support to handle sw breakpoint Madhavan Srinivasan
2014-08-03 15:51 ` Segher Boessenkool [this message]
2014-08-11 3:59 ` Madhavan Srinivasan
2014-08-11 7:26 ` Alexander Graf
2014-08-11 8:51 ` Benjamin Herrenschmidt
2014-08-11 9:15 ` Alexander Graf
2014-08-12 5:17 ` Madhavan Srinivasan
2014-08-12 11:19 ` Alexander Graf
2014-08-12 11:35 ` Madhavan Srinivasan
2014-08-12 12:15 ` Alexander Graf
2014-08-12 12:21 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140803155108.GA19710@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).