From: Jiri Olsa <jolsa@redhat.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
dev@codyps.com, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v6 2/4] tools/perf: extend format_alias() to include event parameters
Date: Tue, 6 Jan 2015 10:39:10 +0100 [thread overview]
Message-ID: <20150106093910.GA24841@krava.brq.redhat.com> (raw)
In-Reply-To: <1419234567-22784-3-git-send-email-sukadev@linux.vnet.ibm.com>
On Sun, Dec 21, 2014 at 11:49:25PM -0800, Sukadev Bhattiprolu wrote:
> From: Cody P Schafer <cody@linux.vnet.ibm.com>
>
> This causes `perf list pmu` to show parameters for parameterized events
> like:
>
> pmu/event_name,param1=?,param2=?/ [Kernel PMU event]
>
> An example:
>
> hv_24x7/HPM_TLBIE__PHYS_CORE,core=?/ [Kernel PMU event]
>
> Changelog[v6]
> [Jir Olsa, Sukadev Bhattiprolu] Drop the '$' sign and go back to
> just printing whatevever sysfs provides (which is '=?') to identify
> required parameters. sysfs also now uses parameters like 'core'
> and 'vcpu' rather than 'starting_index'.
>
> Changelog[v5]
> [Jiri Olsa, Peter Zijlstra] Use '$' to prefix parameterized events.
>
> Changelog[v4]
> [Jiri Olsa] If the parameter for an event in sysfs is 'param=val',
> have perf-list show the event as 'param=?' rather than 'val=?'.
>
> CC: Haren Myneni <hbabu@us.ibm.com>
> CC: Cody P Schafer <dev@codyps.com>
> Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> ---
> tools/perf/util/pmu.c | 27 ++++++++++++++++++++++++++-
> 1 file changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index cb516dd..d208fef 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -810,10 +810,35 @@ void perf_pmu__set_format(unsigned long *bits, long from, long to)
> set_bit(b, bits);
> }
>
> +static int sub_non_neg(int a, int b)
> +{
> + if (b > a)
> + return 0;
> + return a - b;
> +}
> +
> static char *format_alias(char *buf, int len, struct perf_pmu *pmu,
> struct perf_pmu_alias *alias)
> {
> - snprintf(buf, len, "%s/%s/", pmu->name, alias->name);
> + struct parse_events_term *term;
> + int used = snprintf(buf, len, "%s/%s", pmu->name, alias->name);
> +
> + list_for_each_entry(term, &alias->terms, list)
> + if (term->type_val == PARSE_EVENTS__TERM_TYPE_STR)
> + used += snprintf(buf + used, sub_non_neg(len, used),
> + ",%s=%s", term->config,
> + term->val.str);
why not display PARSE_EVENTS__TERM_TYPE_NUM as well?
jirka
next prev parent reply other threads:[~2015-01-06 9:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 7:49 [PATCH v6 0/4] Add support for parametrized events Sukadev Bhattiprolu
2014-12-22 7:49 ` [PATCH v6 1/4] tools/perf: support parsing parameterized events Sukadev Bhattiprolu
2014-12-22 14:37 ` Jiri Olsa
2014-12-22 19:30 ` Sukadev Bhattiprolu
2014-12-23 9:55 ` Jiri Olsa
2014-12-23 19:58 ` Sukadev Bhattiprolu
2015-01-06 9:42 ` Jiri Olsa
2015-01-06 13:26 ` Arnaldo Carvalho de Melo
2014-12-22 7:49 ` [PATCH v6 2/4] tools/perf: extend format_alias() to include event parameters Sukadev Bhattiprolu
2015-01-06 9:39 ` Jiri Olsa [this message]
2015-01-07 23:41 ` Sukadev Bhattiprolu
2015-01-06 9:40 ` Jiri Olsa
2014-12-22 7:49 ` [PATCH v6 3/4] perf Documentation: add " Sukadev Bhattiprolu
2014-12-22 14:39 ` Jiri Olsa
2014-12-22 19:34 ` Sukadev Bhattiprolu
2014-12-23 9:51 ` Jiri Olsa
2014-12-23 19:59 ` Sukadev Bhattiprolu
2014-12-22 7:49 ` [PATCH v6 4/4] tools/perf: Document parameterized and symbolic events Sukadev Bhattiprolu
2014-12-22 14:43 ` Jiri Olsa
2014-12-22 19:45 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106093910.GA24841@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=dev@codyps.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).