From: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: benh@au1.ibm.com, sam.bobroff@au1.ibm.com
Subject: [PATCH] powerpc/powernv: Check image loaded or not before calling flash
Date: Fri, 13 Feb 2015 15:18:42 +0530 [thread overview]
Message-ID: <20150213094514.12351.11666.stgit@localhost.localdomain> (raw)
In-Reply-To: <20150212095323.1829.45732.stgit@localhost.localdomain>
Present code checks for update_flash_data in opal_flash_term_callback().
update_flash_data has been statically initialized to zero, and that
is the value of FLASH_IMG_READY. Also code update initialization happens
during subsys init.
So if reboot is issued before the subsys init stage then we endup displaying
"Flashing new firmware" message.. which may confuse end user.
This patch fixes above described issue by initializes update_flash status
to invalid state.
Reported-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
---
Ben, Sam,
How about this patch?
Initially I though of changing FLASH_IMG_READY value. But it has a impact
on user space tool. (update_flash checks this value before calling reboot.
See update_show function. Of course we can work around that .. But I thought
this one is simpler approach.
-Vasant
arch/powerpc/platforms/powernv/opal-flash.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/opal-flash.c b/arch/powerpc/platforms/powernv/opal-flash.c
index 5c21d9c..0ff07ff 100644
--- a/arch/powerpc/platforms/powernv/opal-flash.c
+++ b/arch/powerpc/platforms/powernv/opal-flash.c
@@ -120,7 +120,11 @@ static struct image_header_t image_header;
static struct image_data_t image_data;
static struct validate_flash_t validate_flash_data;
static struct manage_flash_t manage_flash_data;
-static struct update_flash_t update_flash_data;
+
+/* Initialize update_flash_data status to No Operation */
+static struct update_flash_t update_flash_data = {
+ .status = FLASH_NO_OP,
+};
static DEFINE_MUTEX(image_data_mutex);
next prev parent reply other threads:[~2015-02-13 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 9:53 [PATCH] powerpc/powernv: Check image loaded or not before calling flash Vasant Hegde
2015-02-12 21:27 ` Benjamin Herrenschmidt
2015-02-13 2:46 ` Sam Bobroff
2015-02-13 5:53 ` Vasant Hegde
2015-02-13 5:52 ` Vasant Hegde
2015-02-13 9:48 ` Vasant Hegde [this message]
2015-02-13 9:56 ` [PATCH v2] " Vasant Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150213094514.12351.11666.stgit@localhost.localdomain \
--to=hegdevasant@linux.vnet.ibm.com \
--cc=benh@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sam.bobroff@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).