From: Christoph Hellwig <hch@lst.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>,
akpm@linux-foundation.org, arnd@arndb.de,
catalin.marinas@arm.com, will.deacon@arm.com,
ysato@users.sourceforge.jp, monstr@monstr.eu, jonas@southpole.se,
cmetcalf@ezchip.com, gxt@mprc.pku.edu.cn, x86@kernel.org,
linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-mips@linux-mips.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] dma-mapping: consolidate dma_set_mask
Date: Thu, 13 Aug 2015 19:58:14 +0200 [thread overview]
Message-ID: <20150813175814.GB21103@lst.de> (raw)
In-Reply-To: <20150813152505.GR7557@n2100.arm.linux.org.uk>
On Thu, Aug 13, 2015 at 04:25:05PM +0100, Russell King - ARM Linux wrote:
> On Thu, Aug 13, 2015 at 05:04:08PM +0200, Christoph Hellwig wrote:
> > diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> > index 1143c4d..260f52a 100644
> > --- a/arch/arm/common/dmabounce.c
> > +++ b/arch/arm/common/dmabounce.c
> > @@ -440,14 +440,6 @@ static void dmabounce_sync_for_device(struct device *dev,
> > arm_dma_ops.sync_single_for_device(dev, handle, size, dir);
> > }
> >
> > -static int dmabounce_set_mask(struct device *dev, u64 dma_mask)
> > -{
> > - if (dev->archdata.dmabounce)
> > - return 0;
> > -
> > - return arm_dma_ops.set_dma_mask(dev, dma_mask);
>
> Are you sure about this? A user of dmabounce gets to request any mask
> with the original code (even though it was never written back... which
> is a separate bug.) After this, it seems that this will get limited
> by the dma_supported() check. As this old code is about bouncing any
> buffer into DMA-able memory, it doesn't care about the DMA mask.
I think you're right. With the default dma_supported implementation
it would be fine, but ARM uses a custom one. I'll keep the arm
specific dma_set_mask implementation for the next round.
next prev parent reply other threads:[~2015-08-13 17:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 15:04 provide more common DMA API functions Christoph Hellwig
2015-08-13 15:04 ` [PATCH 1/5] dma-mapping: consolidate dma_{alloc, free}_{attrs, coherent} Christoph Hellwig
2015-08-13 15:04 ` [PATCH 2/5] dma-mapping: consolidate dma_{alloc,free}_noncoherent Christoph Hellwig
2015-08-13 15:20 ` [PATCH 2/5] dma-mapping: consolidate dma_{alloc, free}_noncoherent Russell King - ARM Linux
2015-08-13 17:55 ` [PATCH 2/5] dma-mapping: consolidate dma_{alloc,free}_noncoherent Christoph Hellwig
2015-08-13 15:04 ` [PATCH 3/5] dma-mapping: cosolidate dma_mapping_error Christoph Hellwig
2015-08-13 15:04 ` [PATCH 4/5] dma-mapping: consolidate dma_supported Christoph Hellwig
2015-08-13 15:04 ` [PATCH 5/5] dma-mapping: consolidate dma_set_mask Christoph Hellwig
2015-08-13 15:25 ` Russell King - ARM Linux
2015-08-13 17:58 ` Christoph Hellwig [this message]
2015-08-17 7:06 provide more common DMA API functions V2 Christoph Hellwig
2015-08-17 7:06 ` [PATCH 5/5] dma-mapping: consolidate dma_set_mask Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813175814.GB21103@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cmetcalf@ezchip.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jonas@southpole.se \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=monstr@monstr.eu \
--cc=sparclinux@vger.kernel.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).