From: Peter Zijlstra <peterz@infradead.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [[PATCH v6 09/10] powerpc/perf/hv-24x7: Use PMU_TXN_READ interface
Date: Tue, 8 Sep 2015 13:29:00 +0200 [thread overview]
Message-ID: <20150908112900.GF3644@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1441703275.7601.5.camel@ellerman.id.au>
On Tue, Sep 08, 2015 at 07:07:55PM +1000, Michael Ellerman wrote:
> On Thu, 2015-09-03 at 20:07 -0700, Sukadev Bhattiprolu wrote:
> > The 24x7 counters in Powerpc allow monitoring a large number of counters
> > simultaneously. They also allow reading several counters in a single
> > HCALL so we can get a more consistent snapshot of the system.
> >
> > Use the PMU's transaction interface to monitor and read several event
> > counters at once. The idea is that users can group several 24x7 events
> > into a single group of events. We use the following logic to submit
> > the group of events to the PMU and read the values:
> >
> > pmu->start_txn() // Initialize before first event
> >
> > for each event in group
> > pmu->read(event); // Queue each event to be read
> >
> > pmu->commit_txn() // Read/update all queuedcounters
> >
> > The ->commit_txn() also updates the event counts in the respective
> > perf_event objects. The perf subsystem can then directly get the
> > event counts from the perf_event and can avoid submitting a new
> > ->read() request to the PMU.
> >
> > Thanks to input from Peter Zijlstra.
> >
> > Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> > ---
> > arch/powerpc/perf/hv-24x7.c | 166 ++++++++++++++++++++++++++++++++++++++++++-
>
> This looks fine to me from an arch perspective. I assume the whole series can
> go via tip-something?
Yeah, I've had it queued for a few days, there was one s390 compile
fail reported by the build-bot, which I've just fixed. So if nothing
weird happens, it should hit tip somewhere this week.
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Thanks!
next prev parent reply other threads:[~2015-09-08 11:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 3:07 [PATCH v6 0/10] perf: Implement group-read of events using txn interface Sukadev Bhattiprolu
2015-09-04 3:07 ` [[PATCH v6 01/10] sparc/perf: Remove unnecessary assignment Sukadev Bhattiprolu
2015-09-04 3:07 ` [[PATCH v6 02/10] perf: Add a flags parameter to pmu txn interfaces Sukadev Bhattiprolu
2015-09-04 10:07 ` Michael Ellerman
2015-09-04 3:07 ` [[PATCH v6 03/10] perf: Split perf_event_read() and perf_event_count() Sukadev Bhattiprolu
2015-09-04 3:07 ` [[PATCH v6 04/10] perf: Rename perf_event_read_{one, group}, perf_read_hw Sukadev Bhattiprolu
2015-09-04 3:07 ` [[PATCH v6 05/10] perf: Add group reads to perf_event_read() Sukadev Bhattiprolu
2015-09-04 3:07 ` [[PATCH v6 06/10] perf: Invert perf_read_group() loops Sukadev Bhattiprolu
2015-09-04 3:07 ` [[PATCH v6 07/10] perf: Add return value for perf_event_read() Sukadev Bhattiprolu
2015-09-04 3:07 ` [[PATCH v6 08/10] Define PERF_PMU_TXN_READ interface Sukadev Bhattiprolu
2015-09-04 3:07 ` [[PATCH v6 09/10] powerpc/perf/hv-24x7: Use PMU_TXN_READ interface Sukadev Bhattiprolu
2015-09-08 9:07 ` Michael Ellerman
2015-09-08 11:29 ` Peter Zijlstra [this message]
2015-09-09 2:15 ` Michael Ellerman
2015-09-09 21:12 ` Sukadev Bhattiprolu
2015-09-10 0:43 ` Michael Ellerman
2015-09-04 3:07 ` [[PATCH v6 10/10] perf: Drop PERF_EVENT_TXN Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908112900.GF3644@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=sparclinux@vger.kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).