From: Vladimir Davydov <vdavydov@parallels.com>
To: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Cc: <benh@kernel.crashing.org>, <paulus@samba.org>,
<mpe@ellerman.id.au>, <anton@samba.org>,
<akpm@linux-foundation.org>, <nacc@linux.vnet.ibm.com>,
<gkurz@linux.vnet.ibm.com>, <zhong@linux.vnet.ibm.com>,
<grant.likely@linaro.org>, <nikunj@linux.vnet.ibm.com>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>
Subject: Re: [PATCH 1/2] mm: Replace nr_node_ids for loop with for_each_node in list lru
Date: Mon, 14 Sep 2015 15:04:55 +0300 [thread overview]
Message-ID: <20150914120455.GD30743@esperanza> (raw)
In-Reply-To: <55F6B1F3.1010702@linux.vnet.ibm.com>
On Mon, Sep 14, 2015 at 05:09:31PM +0530, Raghavendra K T wrote:
> On 09/14/2015 02:30 PM, Vladimir Davydov wrote:
> >On Wed, Sep 09, 2015 at 12:01:46AM +0530, Raghavendra K T wrote:
> >>The functions used in the patch are in slowpath, which gets called
> >>whenever alloc_super is called during mounts.
> >>
> >>Though this should not make difference for the architectures with
> >>sequential numa node ids, for the powerpc which can potentially have
> >>sparse node ids (for e.g., 4 node system having numa ids, 0,1,16,17
> >>is common), this patch saves some unnecessary allocations for
> >>non existing numa nodes.
> >>
> >>Even without that saving, perhaps patch makes code more readable.
> >
> >Do I understand correctly that node 0 must always be in
> >node_possible_map? I ask, because we currently test
> >lru->node[0].memcg_lrus to determine if the list is memcg aware.
> >
>
> Yes, node 0 is always there. So it should not be a problem.
I think it should be mentioned in the comment to list_lru_memcg_aware
then.
Thanks,
Vladimir
next prev parent reply other threads:[~2015-09-14 12:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 18:31 [PATCH 0/2] Replace nr_node_ids for loop with for_each_node Raghavendra K T
2015-09-08 18:31 ` [PATCH 1/2] mm: Replace nr_node_ids for loop with for_each_node in list lru Raghavendra K T
2015-09-14 9:00 ` Vladimir Davydov
2015-09-14 11:39 ` Raghavendra K T
2015-09-14 12:04 ` Vladimir Davydov [this message]
2015-09-14 13:05 ` Raghavendra K T
2015-09-14 13:27 ` Vladimir Davydov
2015-09-08 18:31 ` [PATCH 2/2] powerpc:numa Do not allocate bootmem memory for non existing nodes Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914120455.GD30743@esperanza \
--to=vdavydov@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=gkurz@linux.vnet.ibm.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nacc@linux.vnet.ibm.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).