From: Michael Ellerman <mpe@ellerman.id.au>
To: Russell Currey <ruscur@russell.cc>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [V3] powerpc/powernv: Add a kmsg_dumper that flushes console output on panic
Date: Mon, 11 Jan 2016 20:14:02 +1100 (AEDT) [thread overview]
Message-ID: <20160111091402.BDBAB1402DE@ozlabs.org> (raw)
In-Reply-To: <1448605387-2043-1-git-send-email-ruscur@russell.cc>
On Fri, 2015-27-11 at 06:23:07 UTC, Russell Currey wrote:
> On BMC machines, console output is controlled by the OPAL firmware and is
> only flushed when its pollers are called. When the kernel is in a panic
> state, it no longer calls these pollers and thus console output does not
> completely flush, causing some output from the panic to be lost.
>
> Output is only actually lost when the kernel is configured to not power off
> or reboot after panic (i.e. CONFIG_PANIC_TIMEOUT is set to 0) since OPAL
> flushes the console buffer as part of its power down routines. Before this
> patch, however, only partial output would be printed during the timeout wait.
>
> This patch adds a new kmsg_dumper which gets called at panic time to ensure
> panic output is not lost. It accomplishes this by calling OPAL_CONSOLE_FLUSH
> in the OPAL API, and if that is not available, the pollers are called enough
> times to (hopefully) completely flush the buffer.
>
> The flushing mechanism will only affect output printed at and before the
> kmsg_dump call in kernel/panic.c:panic(). As such, the "end Kernel panic"
> message may still be truncated as follows:
>
> >Call Trace:
> >[c000000f1f603b00] [c0000000008e9458] dump_stack+0x90/0xbc (unreliable)
> >[c000000f1f603b30] [c0000000008e7e78] panic+0xf8/0x2c4
> >[c000000f1f603bc0] [c000000000be4860] mount_block_root+0x288/0x33c
> >[c000000f1f603c80] [c000000000be4d14] prepare_namespace+0x1f4/0x254
> >[c000000f1f603d00] [c000000000be43e8] kernel_init_freeable+0x318/0x350
> >[c000000f1f603dc0] [c00000000000bd74] kernel_init+0x24/0x130
> >[c000000f1f603e30] [c0000000000095b0] ret_from_kernel_thread+0x5c/0xac
> >---[ end Kernel panic - not
>
> This functionality is implemented as a kmsg_dumper as it seems to be the
> most sensible way to introduce platform-specific functionality to the
> panic function.
>
> Signed-off-by: Russell Currey <ruscur@russell.cc>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/affddff69c55eb68969448f35f
cheers
next prev parent reply other threads:[~2016-01-11 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 6:23 [PATCH V3] powerpc/powernv: Add a kmsg_dumper that flushes console output on panic Russell Currey
2016-01-11 9:14 ` Michael Ellerman [this message]
2016-01-12 3:44 ` [V3] " Stewart Smith
2016-01-12 4:17 ` Russell Currey
2016-01-12 12:05 ` Michael Ellerman
2016-01-15 4:59 ` Stewart Smith
2016-01-15 10:07 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111091402.BDBAB1402DE@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).