From: Rob Herring <robh@kernel.org>
To: Zhao Qiang <qiang.zhao@nxp.com>
Cc: oss@buserror.net, leoyang.li@nxp.com, xiaobo.xie@nxp.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
Date: Fri, 4 Mar 2016 22:25:36 -0600 [thread overview]
Message-ID: <20160305042536.GD13525@rob-hp-laptop> (raw)
In-Reply-To: <1456816183-22340-3-git-send-email-qiang.zhao@nxp.com>
On Tue, Mar 01, 2016 at 03:09:39PM +0800, Zhao Qiang wrote:
> Add uqe_serial document to
> Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2
> - modify tx/rx-clock-name specification
> Changes for v2
> - NA
>
> .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
>
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> new file mode 100644
> index 0000000..436c71c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> @@ -0,0 +1,19 @@
> +* Serial
> +
> +Currently defined compatibles:
> +- ucc_uart
I guess this is in use already and okay. However, looking at the driver
there really should be SoC specific compatible strings here since the
driver is looking up the SoC compatible string and composing the
firmware filename from that.
> +
> +Properties for ucc_uart:
> +port-number : port number of UCC-UART
> +tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source,
> + should be "clk1"-"clk28" for external clock source.
> +
> +Example:
> +
> + ucc_serial: ucc@2200 {
> + device_type = "serial";
Drop device_type. It should only be used in a few legacy cases.
Looks like the driver is matching on this. Please drop it from the
driver too. I'd leave dts files for now, but they should be updated too
later.
> + compatible = "ucc_uart";
> + port-number = <1>;
> + rx-clock-name = "brg2";
> + tx-clock-name = "brg2";
> + };
> --
> 2.1.0.27.g96db324
>
next prev parent reply other threads:[~2016-03-05 4:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 7:09 [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
2016-03-01 7:09 ` [PATCH v3 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
2016-03-05 4:25 ` Rob Herring
2016-03-01 7:09 ` [PATCH v3 3/7] QE: Add uqe_serial " Zhao Qiang
2016-03-05 4:25 ` Rob Herring [this message]
2016-03-07 2:35 ` Qiang Zhao
2016-03-07 17:28 ` Scott Wood
2016-03-08 1:16 ` Qiang Zhao
2016-03-09 0:13 ` Scott Wood
2016-03-01 7:09 ` [PATCH v3 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl Zhao Qiang
2016-03-05 4:25 ` Rob Herring
2016-03-01 7:09 ` [PATCH v3 5/7] T104xD4RDB: Add qe node to t104xd4rdb Zhao Qiang
2016-03-01 7:09 ` [PATCH v3 6/7] T104xRDB: Add qe node to t104xrdb Zhao Qiang
2016-03-01 7:09 ` [PATCH v3 7/7] T104xQDS: Add qe node to t104xqds Zhao Qiang
2016-03-05 4:25 ` [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305042536.GD13525@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=qiang.zhao@nxp.com \
--cc=xiaobo.xie@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).